From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3E95D1B681 for ; Fri, 13 Oct 2017 11:58:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 49BDB207A2; Fri, 13 Oct 2017 05:58:15 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 05:58:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=n02kZaGtbLdujwW4/YwFn5btLB AzHAvrsQ2owi1K1Kw=; b=QLP2GYWEbjoRulYmE3hnFtn7mE983mfYzSOdD/5w+y cD/ITa2jv3i1PZmqRBW4/WMADlLVAOdKMhQDJgP5uvlVqwdvUwep57BEQ4iwX8iA 6DzBbf3U8anMytQVC0t6G4B59lYprIE5cjeBYyGehqdko2nyAizqWI873zLoAet+ E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=n02kZa GtbLdujwW4/YwFn5btLBAzHAvrsQ2owi1K1Kw=; b=hTHdqTQHs1NwQCBfz5VYbq RhutoRa+ZUNH1En9u6YLy8A58Xii+z3B88QnBl421Rf8cUK4m0r83B3XShbOYjL9 EPnbjPjurE9LOFCQxM9v3tii5kZuX2SzgTsj/htKqGS3Yv1a+bOwRx7AMam/eZVc FsDWewWi1FlYfTuNpaNME8ifQoqu+L/r7SnVjhx7ejZvBWON3DNMYV5z0aB0atMd ZDtmYccMCqrmKna+GiUCoovMJ6ctgN1NwVOqDLYlbNHyhjvKFQrl7fJLze0AT+B4 CphXL10p6BIBM8P6weS4u0fT4uSK9GWTLTIpnlwywZQ64E5DON7l3JcWY3y21INA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E3ED0248DD; Fri, 13 Oct 2017 05:58:14 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin , Santosh Shukla Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, aconole@redhat.com, stephen@networkplumber.org, anatoly.burakov@intel.com, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, bruce.richardson@intel.com, sergio.gonzalez.monroy@intel.com Date: Fri, 13 Oct 2017 11:58:14 +0200 Message-ID: <3683509.TTr5eYlGSc@xps> In-Reply-To: References: <20170920112356.17629-1-santosh.shukla@caviumnetworks.com> <20171006110346.13247-7-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 6/9] eal: auto detect iova mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 09:58:16 -0000 13/10/2017 10:48, Maxime Coquelin: > Hi Santosh, > > On 10/06/2017 01:03 PM, Santosh Shukla wrote: > > iova autodetection depends on rte_bus_scan result. Result of bus scan will > > have updated device_list and each device in that list has its '.kdev' state > > updated. That kdrv state used to detect iova mapping mode for that device. > > > > _device_parse() has dependency on rt_bus_scan so, > > Below calls moved up in the eal initialization order: > > - eal_option_device_parse > > - rte_bus_scan > > > > And based on the result of rte_bus_scan_iommu_class - select iova > > mapping mode. > > > > Signed-off-by: Santosh Shukla > > Signed-off-by: Jerin Jacob > > Reviewed-by: Maxime Coquelin > > Reviewed-by: Anatoly Burakov > > Tested-by: Hemant Agrawal > > --- > > lib/librte_eal/bsdapp/eal/eal.c | 27 ++++++++++++++++----------- > > lib/librte_eal/linuxapp/eal/eal.c | 27 ++++++++++++++++----------- > > 2 files changed, 32 insertions(+), 22 deletions(-) > > We noticed a regression on current master, which prevents to use Vhost > PMD with CONFIG_RTE_BUILD_SHARED_LIB=y: It was my guess during review: http://dpdk.org/ml/archives/dev/2017-October/077863.html I really don't understand how it can work, because the bus scan is moved before shared libraries (plugins) are loaded. It will be even worst when PCI and vdev buses will be some shared libraries. Is it a chicken/egg issue? If we cannot find a good solution, we may have to revert for RC1.