From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 52A122C8 for ; Wed, 23 May 2018 12:14:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C564C21B1F; Wed, 23 May 2018 06:14:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 23 May 2018 06:14:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=bFRYUNyBqs8JGdST+EjFTcKyuI G72C/StCB4tFA/3uk=; b=XpTFlKK9Q3CMJIVuXK2/kd18IKjYn54mbiwD1GJC4F fWNI1vC9SxmMrY6OcArL1zZ7vHR6FVyh9B5nhBOjTnsgJMkVVQP9Bwj+egtnVIWY N5WdJMH0gYcc3igkkpyGyFXdBBbh9CLAUlwQVkK3UOw7S5+9jOxJWg/ikzDNFBFn w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bFRYUN yBqs8JGdST+EjFTcKyuIG72C/StCB4tFA/3uk=; b=csfVBja1WvXlxfr6cIlmxU Gjk3tJwfVfNQ2iwuD+8sGspVPxdu/VDuFQejKSC84n+p0KYs0ZlezI2mf0NAqp2N WKd4do3f7KJE7AU1Zaj+VKjjpr1alp/a+tCAPgR08F2Y55tK4l1+45oc7eI1yD9f 9GwXsmkH78nPHijWxuFlG0H8xB2leB+BkoJBkj1l8F3ITRoffGZwTvcrVSvu6aB1 TgvylBtvI3HumI80+h/SzMMCkt4cjgj7Ie4vzPCeMjZ5W12bUoOU/k6eqNZrlI3R NVcuQd4mygY8iLE65BhSfpfKoRPaYUnTWOjcJMn/tD2D5DF9p0G0BbVilPbh69bA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8C3E5E47F2; Wed, 23 May 2018 06:14:26 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, matan@mellanox.com, arybchenko@solarflare.com, stephen@networkplumber.org, Keith Wiles , Jasvinder Singh Date: Wed, 23 May 2018 12:14:25 +0200 Message-ID: <3685038.uD5Rg6BZkV@xps> In-Reply-To: References: <20180509094337.26112-1-thomas@monjalon.net> <20180510235836.1099-6-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 05/11] ethdev: add probing finish function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2018 10:14:28 -0000 23/05/2018 12:09, Ferruh Yigit: > On 5/11/2018 12:58 AM, Thomas Monjalon wrote: > > A new hook function is added and called inside the PMDs at the end > > of the device probing: > > - in primary process, after allocating, init and config > > - in secondary process, after attaching and local init > > > > This new function is almost empty for now. > > It will be used later to add some post-initialization processing. > > > > For the PMDs calling the helpers rte_eth_dev_create() or > > rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish() > > is called from here, and not in the PMD itself. > > > > Note that the helper rte_eth_dev_create() could be used more, > > especially for vdevs, avoiding some code duplication in PMDs. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: Andrew Rybchenko > > Reviewed-by: Stephen Hemminger > > Hi Thomas, > > This change forces PMDs to call rte_eth_dev_probing_finish() to have them in > proper state. But this requirement is not very clear and documented, it is easy > to miss! > > Does it make sense update release notes and highlight to say all PMDs should > call rte_eth_dev_probing_finish(), directly or via helper functions? You want to make PMD developers aware of this change? It's not a new feature, and not an API change, so I don't know where to write it.