From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 78B771B989 for ; Tue, 15 May 2018 12:51:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 063A628006C; Tue, 15 May 2018 10:51:18 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 15 May 2018 11:51:14 +0100 To: Andy Green , CC: References: <2DBBFF226F7CF64BAFCA79B681719D953A44992E@SHSMSX101.ccr.corp.intel.com> <152636946035.95095.1840276672620244597.stgit@localhost.localdomain> From: Andrew Rybchenko Message-ID: <369bf5db-ad87-73cb-3470-901fe243c4a2@solarflare.com> Date: Tue, 15 May 2018 13:51:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <152636946035.95095.1840276672620244597.stgit@localhost.localdomain> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23844.003 X-TM-AS-Result: No--7.328300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1526381479-LZ4a8Zu1L8lR Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 10:51:20 -0000 On 05/15/2018 10:31 AM, Andy Green wrote: > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") > Signed-off-by: Andy Green Reviewed-by: Andrew Rybchenko Suggest to reword it as: bus/pci: fix invalid size of driver name buffer Variable dri_name is a pointer and it is incorrect to use its size as the buffer size. Caller knows the buffer size and it is safer to pass it explicitly.