From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B7E2A09FF; Wed, 6 Jan 2021 10:14:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94EF6160852; Wed, 6 Jan 2021 10:14:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id C84E21607E9 for ; Wed, 6 Jan 2021 10:14:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609924473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlXzyTRBuDmwZk1WINlPRSaLERpuYYH6eGmQCyF4mPo=; b=QdKimIxc/QdF9wSyhWzKlV7PMZMa8mtzTRKrE1+tHK6xaa/tFvhGZKXWz/4q5/qesQEBb3 sg8uU82BcZcI+1xLghrlU2T/K0Vss85bbAYTF2kA+DhL+eFjDPArOXAQHwO7VCVdqKTX9m 1FMz6bIzRjN4/SdCOyKgHWpExec3SnM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-S8kuNADfOm2tZTMNgdQFIw-1; Wed, 06 Jan 2021 04:14:30 -0500 X-MC-Unique: S8kuNADfOm2tZTMNgdQFIw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB83B425F7; Wed, 6 Jan 2021 09:14:29 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B15E8100AE30; Wed, 6 Jan 2021 09:14:22 +0000 (UTC) To: David Marchand , Ray Kinsella , Thomas Monjalon Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-9-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <369d28c6-53c0-b8a7-0500-abdd91672fd5@redhat.com> Date: Wed, 6 Jan 2021 10:14:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/6/21 10:06 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin > wrote: >> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c >> index 1f1f63a1a5..f4775ff141 100644 >> --- a/drivers/net/virtio/virtio_user_ethdev.c >> +++ b/drivers/net/virtio/virtio_user_ethdev.c >> @@ -663,6 +663,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) >> char *mac_addr = NULL; >> int ret = -1; >> >> + /* >> + * ToDo 1: Implement detection mechanism at vdev bus level as PCI, but >> + * it implies API breakage. > > Extending rte_vdev_driver to implement this detection would be an ABI breakage. > This is a driver-only API (rte_vdev_driver is only used by the vdev > bus and drivers afaics). > > Doing this is allowed as per my understanding of the ABI policy which > guarantees ABI stability for applications. > We do not guarantee this stability for OOT drivers. > That would be a good news, as it would remove impacting the user by requiring him to manually add --iova-mode=va in the EAL parameters. I can change this in the v2 if this is confirmed. Ray, Thomas, is that OK for you? Thanks, Maxime