From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD208A0545; Thu, 25 Aug 2022 16:08:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D3F94281E; Thu, 25 Aug 2022 16:08:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D6772415D7 for ; Thu, 25 Aug 2022 16:08:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661436530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=srHGf7ANhxLon27741fwWeEE3KJV8Ro5/K85evTwf14=; b=VcQOabzTGLS8+y7jVDmqe8ZLIcBelJ/sEcxbMYYqhtT4moEEJyaCIV2RAkTXjajspwW92e vKY+Bqjk8wB7YeiiG1vg4K68cD9KVKgo5mt7m5rPFqec9a6g81ocyJhrgpTRpLlXwgOx6Q 69raEDgay4leKbLCFXdN4Zb2eaOoPNU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-670-AWMwU1OKMo2OElsi7fzgJQ-1; Thu, 25 Aug 2022 10:08:48 -0400 X-MC-Unique: AWMwU1OKMo2OElsi7fzgJQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86709811E9B; Thu, 25 Aug 2022 14:08:47 +0000 (UTC) Received: from [10.39.208.44] (unknown [10.39.208.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D6242026D64; Thu, 25 Aug 2022 14:08:45 +0000 (UTC) Message-ID: <36af7910-1c40-ec14-59d1-423a1cc2f4be@redhat.com> Date: Thu, 25 Aug 2022 16:08:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 2/7] bbdev: add device status info To: "Chautru, Nicolas" , Tom Rix , "dev@dpdk.org" , "thomas@monjalon.net" , "gakhil@marvell.com" , "hemant.agrawal@nxp.com" Cc: "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-1-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-3-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/6/22 23:16, Chautru, Nicolas wrote: >>> +}; >>> + >>> /** Device statistics. */ >>> struct rte_bbdev_stats { >>> uint64_t enqueued_count; /**< Count of all operations enqueued */ >>> @@ -285,12 +300,14 @@ struct rte_bbdev_driver_info { >>> /** Set if device supports per-queue interrupts */ >>> bool queue_intr_supported; >>> /** Minimum alignment of buffers, in bytes */ >>> - uint16_t min_alignment; >>> - /** HARQ memory available in kB */ >>> + /** Device Status */ >>> + enum rte_bbdev_device_status device_status; >> New elements should be added to the end to improve backward compatibility. > Same comment in different patch. I would like to know if there is a real recommendation from DPDK on this. I have heard opposite view as well. > In that very case we are breaking the ABI in that new serie for 22.11 (sizes and offsets are changing). > Since we are breaking ABI anyways, I don't find it unreasonable to take the opportunity to improve packing the struct. Maxime