From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>,
oulijun <oulijun@huawei.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: xiaoyun.li@intel.com, dev@dpdk.org, linuxarm@openeuler.org,
Andrew Rybchenko <arybchenko@solarflare.com>,
Aaron Conole <aconole@redhat.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd
Date: Tue, 9 Mar 2021 13:18:59 +0300 [thread overview]
Message-ID: <36b1a9dc-9e5a-85ea-0a1d-51304e0f90a4@oktetlabs.ru> (raw)
In-Reply-To: <1980606.NPtmdolmL5@thomas>
On 3/9/21 12:57 PM, Thomas Monjalon wrote:
> 09/03/2021 10:53, Ferruh Yigit:
>> On 3/9/2021 8:49 AM, oulijun wrote:
>>> 2021/3/9 1:33, Ferruh Yigit:
>>>> Similar to above comment 'rte_eth_devices' is the internal variable,
>>>> applications should not access it directly.
>>>>
>>> No API is available, and multiple references exist in the testpmd file.
>>
>> Technically 'rte_eth_devices' is still visible to the applications because of
>> the static inline functions, in theory it should be hidden.
>>
>> But this variable accessed by our test application multiple times may be the
>> sign that something more is missing.
>>
>> Thomas, Andrew, what to you think to try to clean this usage from testpmd and
>> add more APIs if needed for this?
>
> I fully agree.
> The test applications and examples should help identifying gaps
> in the libraries. So we should not workaround the official API.
>
+1
next prev parent reply other threads:[~2021-03-09 10:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 7:33 [dpdk-dev] [PATCH] " Lijun Ou
2021-03-05 7:46 ` Li, Xiaoyun
2021-03-05 9:58 ` oulijun
2021-03-05 9:57 ` [dpdk-dev] [PATCH V2] " Lijun Ou
2021-03-08 17:33 ` Ferruh Yigit
2021-03-09 8:49 ` oulijun
2021-03-09 9:53 ` Ferruh Yigit
2021-03-09 9:57 ` Thomas Monjalon
2021-03-09 10:18 ` Andrew Rybchenko [this message]
2021-03-09 14:00 ` Aaron Conole
2021-03-09 14:13 ` Ferruh Yigit
2021-03-10 1:48 ` oulijun
2021-03-10 7:59 ` Thomas Monjalon
2021-03-12 10:29 ` [dpdk-dev] [Linuxarm] " oulijun
2021-03-12 11:21 ` Thomas Monjalon
2021-03-17 11:30 ` oulijun
2021-03-17 12:07 ` Thomas Monjalon
2021-03-18 3:56 ` oulijun
2021-03-18 7:51 ` Thomas Monjalon
2021-04-12 13:12 ` [dpdk-dev] [PATCH V3] " Lijun Ou
2021-04-19 3:11 ` Li, Xiaoyun
2021-04-19 12:40 ` oulijun
2021-04-19 14:56 ` Ferruh Yigit
2021-04-19 12:36 ` [dpdk-dev] [PATCH V4] " Lijun Ou
2021-04-19 15:28 ` Ferruh Yigit
2021-04-21 1:44 ` oulijun
2021-04-21 8:09 ` [dpdk-dev] [PATCH V5] app/test-pmd: support cleanup txq mbufs command Lijun Ou
2021-04-21 8:15 ` Ferruh Yigit
2021-04-21 8:32 ` oulijun
2021-04-21 8:45 ` [dpdk-dev] [PATCH V6] " Lijun Ou
2021-04-21 11:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b1a9dc-9e5a-85ea-0a1d-51304e0f90a4@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@openeuler.org \
--cc=oulijun@huawei.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).