From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A20F5A0559; Mon, 16 Mar 2020 03:02:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C96C94CA6; Mon, 16 Mar 2020 03:02:31 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1A1D825D9; Mon, 16 Mar 2020 03:02:28 +0100 (CET) IronPort-SDR: xTccqXaba2J17+XWKNgpqJrgUT6zuoRWjBdaJjRuDM+ZOnTx6tIHpbNYgBvgL3Nryb8sj7GW2B wLAiYkq7/1tQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2020 19:02:26 -0700 IronPort-SDR: 6m0SmfP3bPwiMOp6tFXI3Uwqsyi4ymqA8JyDQBhWDDL/cOUouHXt01HjZ2pUcT707KJkQEdbJf 4g4HVHmT6aJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,558,1574150400"; d="scan'208";a="390547769" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 15 Mar 2020 19:02:26 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Mar 2020 19:02:26 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Mar 2020 10:02:23 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Mon, 16 Mar 2020 10:02:23 +0800 From: "Li, Xiaoyun" To: Kevin Traynor , Zhike Wang , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation Thread-Index: AQHV+WvvSbpMnhEPA0GklngkXQStVKhKdQiA Date: Mon, 16 Mar 2020 02:02:23 +0000 Message-ID: <36b37ce80e63461cbb6ec200abfeb38a@intel.com> References: <1579137597-14076-1-git-send-email-wangzhike@jd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable adminq operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Kevin Traynor [mailto:ktraynor@redhat.com] > Sent: Saturday, March 14, 2020 03:16 > To: Li, Xiaoyun ; Zhike Wang ; > dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > stable@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgemen= t > when disable adminq operation >=20 > On 13/03/2020 04:40, Li, Xiaoyun wrote: > > Hi > > > > This issue is already fixed in 20.02 with base code update of the follo= wing > commit. > > > > > > > > commit 37b091c75b13d2f26359be9b77adbc33c55a7581 > > > > Author: Xiaolong Ye > > > > Date: Mon Jan 13 10:39:31 2020 +0800 > > > > > > > > net/i40e/base: extend PHY access AQ command > > > > > > > > Currently FW use MDIO I/F number corresponded with current PF for P= HY > > > > access. This code allow to specify used MDIO I/F number. > > > > > > > > Signed-off-by: Piotr Azarewicz > > > > Signed-off-by: Xiaolong Ye > > > > Acked-by: Qi Zhang > > > > Acked-by: Beilei Xing beilei.xing@intel.com > > > > > > > > But it makes sense to back port this to stable release so it can work w= ith dpdk > version <=3D19.11. > > > > Still some comments inline. > > > > > > > >> -----Original Message----- > > > >> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhike Wang > > > >> Sent: Thursday, January 16, 2020 09:20 > > > >> To: dev@dpdk.org > > > >> Cc: Xing, Beilei ; Zhang, Qi Z ; > > > >> stable@dpdk.org; Zhike Wang > > > >> Subject: [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disab= le > > > >> adminq operation > > > >> > > > >> X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722 > > > >> /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether i= t is > > > >> X722 or not. > > > >> > > > > Please be careful about your commit log. If you use mac.type =3D=3D X72= 2, then > that's not just X722 SFP but all X722 devices. > > > > You can just say something like X722 doesn't support adminq operation s= o > disable it. > > >=20 > You say commit log, but isn't that what is done in the code? His commit log only says about X722 SFPs but mac.type =3D=3D X722 means all= X722 devices. SFPs are only a part of X722. So I prefer his commit log can explain the root cause. >=20 > > > > > >> Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16") > > > > Please follow the DPDK community code style. Fix line needs commit id o= f 12 > bit. > > > > In this case, should be: Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 w= ith > FW4.16") > > > > And since this fix makes sense for <=3D19.11, please add this line: Cc: > stable@dpdk.org > > >=20 > Please add the stable branches requested in the usual format. >=20 > http://doc.dpdk.org/guides/contributing/patches.html#backporting-patches- > for-stable-releases >=20 > > > > > >> Signed-off-by: Zhike Wang > > > > >> --- > > > >> drivers/net/i40e/i40e_ethdev.c | 2 +- > > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > >> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et= hdev.c > > > >> index 5999c96..85ccb76 100644 > > > >> --- a/drivers/net/i40e/i40e_ethdev.c > > > >> +++ b/drivers/net/i40e/i40e_ethdev.c > > > >> @@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct > > > >> i40e_pf *pf) > > > >> return -EIO; > > > >> } > > > >> /* Firmware of SFP x722 does not support adminq option */ > > > >> - if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722) > > > >> + if (hw->mac.type =3D=3D I40E_MAC_X722) > > > >> hw->flags &=3D ~I40E_HW_FLAG_802_1AD_CAPABL= E; > > > >> > > > >> PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d > > > >> eetrack %04x", > > > >> -- > > > >> 1.8.3.1 > > > >> > >