From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 905DB42D79;
	Wed, 28 Jun 2023 04:59:46 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6A2C442D20;
	Wed, 28 Jun 2023 04:59:46 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 1049840151
 for <dev@dpdk.org>; Wed, 28 Jun 2023 04:59:44 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.55])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QrRBQ1kgwzqV3k;
 Wed, 28 Jun 2023 10:59:26 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.27; Wed, 28 Jun 2023 10:59:42 +0800
Subject: Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config
To: Thomas Monjalon <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
 <lihuisong@huawei.com>
References: <20230626124332.28157-1-liudongdong3@huawei.com>
 <20230627071126.17161-1-liudongdong3@huawei.com>
 <20230627071126.17161-3-liudongdong3@huawei.com> <16389153.hlxOUv9cDv@thomas>
CC: <dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <36dea9f8-2f7d-6efe-b61d-d4ca393bf777@huawei.com>
Date: Wed, 28 Jun 2023 10:59:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <16389153.hlxOUv9cDv@thomas>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Thomas

Many thanks for your review.

On 2023/6/28 7:12, Thomas Monjalon wrote:
> 27/06/2023 09:11, Dongdong Liu:
>> +- ``fdir_vlan_match_mode`` (default `strict`)
>> +
>> +  Used to select VLAN match mode. This runtime config can be `strict`
>> +  or `nostrict` and is only valid for PF drives.
>
> drives? Do you mean devices?
for PF devices, will fix.
>
>> +  If driver works on `strict` mode (default mode), hardware does strictly
>> +  match the input flow base on VLAN number.
>> +
>> +  For the following scenarios with two rules:
>> +
>> +  .. code-block:: console
>> +
>> +    rule0:
>> +      pattern: eth type is 0x0806
>> +      actions: queue index 3
>> +    rule1:
>> +      pattern: eth type is 0x0806 / vlan vid is 20
>> +      actions: queue index 4
>> +
>> +  If application select `strict` mode, only the ARP packets with VLAN
>> +  20 are directed to queue 4, and the ARP packets with other VLAN ID
>> +  cannot be directed to the specified queue. If application want to all
>> +  ARP packets with or without VLAN to be directed to the specified queue,
>> +  application can select `nostrict` mode and just need to set rule0.
>
> As it is done in the rest of the document, you should use double backquotes
> for values of the devargs.
Good point, will fix.

Thanks,
Dongdong.
>
>
>
> .
>