From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 0EDC91BB3B
 for <dev@dpdk.org>; Fri, 14 Dec 2018 14:37:41 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 14 Dec 2018 05:37:41 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,353,1539673200"; d="scan'208";a="303837863"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.85.142])
 ([10.251.85.142])
 by fmsmga005.fm.intel.com with ESMTP; 14 Dec 2018 05:37:40 -0800
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: lei.a.yao@intel.com
References: <20181214114946.21570-1-david.hunt@intel.com>
 <20181214133137.23516-1-david.hunt@intel.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <36e6f6f0-8632-96d5-697f-905745778bbe@intel.com>
Date: Fri, 14 Dec 2018 13:37:37 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <20181214133137.23516-1-david.hunt@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 0/4] examples/power: allow use of more
	than 64 cores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 13:37:42 -0000

On 14-Dec-18 1:31 PM, David Hunt wrote:
> First of all we convert all the relevant uint64_t's to char arrays. Then
> we remove the unneeded mask functions that were limited to 64 cores. Also
> extend the guest functionality and finally rause the number of supported
> cores to something more sensible, i.e. 256.
> 
> v2 changes:
>    * Updates out of Review by Anatoly.
>    * Indentation fixes
>    * resolved missing spinlock around config updates
>    * simplified some loops
>    * fixed bug in non-equivalent code
> 
> v3 changes:
>    * Moved a spinlock to a more appropriate place. Was in a for-loop, made
>      more sense to have it outside.
> 
> [1/4] examples/power: change 64-bit masks to arrays
> [2/4] examples/power: remove mask functions
> [3/4] examples/power: allow vms to use lcores over 63
> [4/4] examples/power: increase max cores to 256
> 
> 

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly