DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	john.mcnamara@intel.com, marko.kovacevic@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add NASM installation steps
Date: Wed, 20 May 2020 11:38:47 +0100	[thread overview]
Message-ID: <36f91b7b-47c7-fed0-de6d-71fb7e4d6870@redhat.com> (raw)
In-Reply-To: <1589790958-285679-1-git-send-email-pablo.de.lara.guarch@intel.com>

On 18/05/2020 09:35, Pablo de Lara wrote:
> The intel-ipsec-mb library requires NASM as a dependency.

Hi Pablo,

Thanks for the patch. Couple of comments below.

Kevin.

> Steps on how to get and install NASM are added on the documentation
> of the crypto PMDs which requires the library.
> 

Bugzilla ID: 417

> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/cryptodevs/aesni_gcm.rst | 14 ++++++++++++++
>  doc/guides/cryptodevs/aesni_mb.rst  | 14 ++++++++++++++
>  doc/guides/cryptodevs/kasumi.rst    | 14 ++++++++++++++
>  doc/guides/cryptodevs/snow3g.rst    | 14 ++++++++++++++
>  doc/guides/cryptodevs/zuc.rst       | 14 ++++++++++++++
>  5 files changed, 70 insertions(+)
> 
> diff --git a/doc/guides/cryptodevs/aesni_gcm.rst b/doc/guides/cryptodevs/aesni_gcm.rst
> index 7dfd0ca..e4b0e7e 100644
> --- a/doc/guides/cryptodevs/aesni_gcm.rst
> +++ b/doc/guides/cryptodevs/aesni_gcm.rst
> @@ -50,6 +50,20 @@ can be downloaded in `<https://github.com/01org/intel-ipsec-mb/archive/v0.54.zip
>      make
>      make install
>  
> +The library requires NASM to be built. Depending on the library version, it might
> +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14).
> +
> +NASM is packaged for different OS. However, on some OS the version is too old,
> +so a manual installation is required. In that case, NASM can be downloaded from
> +`here <https://www.nasm.us/pub/nasm/releasebuilds/?C=M;O=D>`_.

Getting some warnings because of the 'here':
$ make doc-guides-html
sphinx processing guides-html..
/home/ktraynor/code/dpdk/doc/guides/cryptodevs/aesni_gcm.rst:5: WARNING:
Duplicate explicit target name: "here".
/home/ktraynor/code/dpdk/doc/guides/cryptodevs/aesni_mb.rst:5: WARNING:
Duplicate explicit target name: "here".
/home/ktraynor/code/dpdk/doc/guides/cryptodevs/kasumi.rst:5: WARNING:
Duplicate explicit target name: "here".
/home/ktraynor/code/dpdk/doc/guides/cryptodevs/snow3g.rst:5: WARNING:
Duplicate explicit target name: "here".
/home/ktraynor/code/dpdk/doc/guides/cryptodevs/zuc.rst:5: WARNING:
Duplicate explicit target name: "here".


> +Once it is downloaded, extract it and follow these steps:
> +
> +.. code-block:: console
> +
> +    ./configure
> +    make
> +    make install
> +
>  .. note::
>  
>     Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53.
> diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst
> index a2c3a84..9154fb4 100644
> --- a/doc/guides/cryptodevs/aesni_mb.rst
> +++ b/doc/guides/cryptodevs/aesni_mb.rst
> @@ -75,6 +75,20 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v0.54.z
>      make
>      make install
>  
> +The library requires NASM to be built. Depending on the library version, it might
> +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14).
> +
> +NASM is packaged for different OS. However, on some OS the version is too old,
> +so a manual installation is required. In that case, NASM can be downloaded from
> +`here <https://www.nasm.us/pub/nasm/releasebuilds/?C=M;O=D>`_.
> +Once it is downloaded, extract it and follow these steps:
> +
> +.. code-block:: console
> +
> +    ./configure
> +    make
> +    make install
> +
>  .. note::
>  
>     Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53.
> diff --git a/doc/guides/cryptodevs/kasumi.rst b/doc/guides/cryptodevs/kasumi.rst
> index edbc1c6..4a582a7 100644
> --- a/doc/guides/cryptodevs/kasumi.rst
> +++ b/doc/guides/cryptodevs/kasumi.rst
> @@ -47,6 +47,20 @@ on their system before building DPDK:
>      make
>      make install
>  
> +The library requires NASM to be built. Depending on the library version, it might
> +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14).
> +
> +NASM is packaged for different OS. However, on some OS the version is too old,
> +so a manual installation is required. In that case, NASM can be downloaded from
> +`here <https://www.nasm.us/pub/nasm/releasebuilds/?C=M;O=D>`_.
> +Once it is downloaded, extract it and follow these steps:
> +
> +.. code-block:: console
> +
> +    ./configure
> +    make
> +    make install
> +
>  .. note::
>  
>     Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53.
> diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
> index b715b46..eedc230 100644
> --- a/doc/guides/cryptodevs/snow3g.rst
> +++ b/doc/guides/cryptodevs/snow3g.rst
> @@ -46,6 +46,20 @@ on their system before building DPDK:
>      make
>      make install
>  
> +The library requires NASM to be built. Depending on the library version, it might
> +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14).
> +
> +NASM is packaged for different OS. However, on some OS the version is too old,
> +so a manual installation is required. In that case, NASM can be downloaded from
> +`here <https://www.nasm.us/pub/nasm/releasebuilds/?C=M;O=D>`_.
> +Once it is downloaded, extract it and follow these steps:
> +
> +.. code-block:: console
> +
> +    ./configure
> +    make
> +    make install
> +
>  .. note::
>  
>     Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53.
> diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst
> index c384f3d..0741e57 100644
> --- a/doc/guides/cryptodevs/zuc.rst
> +++ b/doc/guides/cryptodevs/zuc.rst
> @@ -46,6 +46,20 @@ on their system before building DPDK:
>      make
>      make install
>  
> +The library requires NASM to be built. Depending on the library version, it might
> +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14).
> +
> +NASM is packaged for different OS. However, on some OS the version is too old,
> +so a manual installation is required. In that case, NASM can be downloaded from
> +`here <https://www.nasm.us/pub/nasm/releasebuilds/?C=M;O=D>`_.
> +Once it is downloaded, extract it and follow these steps:
> +
> +.. code-block:: console
> +
> +    ./configure
> +    make
> +    make install
> +
>  .. note::
>  
>     Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53.
> 


  reply	other threads:[~2020-05-20 10:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18  8:35 Pablo de Lara
2020-05-20 10:38 ` Kevin Traynor [this message]
2020-05-21  9:29   ` De Lara Guarch, Pablo
2020-05-21  9:15 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2020-05-21  9:27   ` Kevin Traynor
2020-05-24 16:56     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36f91b7b-47c7-fed0-de6d-71fb7e4d6870@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).