From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E695AA0093; Wed, 20 May 2020 12:38:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64E3C1C221; Wed, 20 May 2020 12:38:58 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 4E4A91BF54 for ; Wed, 20 May 2020 12:38:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589971135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=agNB5hxJ57uIh519gtPfcxMBzYFinMeI4+rnNN5khQk=; b=RDgvdUFKTi/GKXW7xvZChQ1tw1PLInDUBXAPyxBpuazijAIE+HPdRF9rAEsp0WykZTw/4f 1jwL2JURk6yC1WT+1Ai2sHeTisSlT03enGLiJP4TTYL7YW6cWCG4PXmcH4NSzD0SQ5U0fX SRtx33JH+1/LjjMn2pyGwdfCeamR2Ds= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-dzJsGUA4OLapnPDLPODetg-1; Wed, 20 May 2020 06:38:50 -0400 X-MC-Unique: dzJsGUA4OLapnPDLPODetg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A7E4835B40; Wed, 20 May 2020 10:38:49 +0000 (UTC) Received: from [10.33.36.190] (unknown [10.33.36.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C2986F7F9; Wed, 20 May 2020 10:38:47 +0000 (UTC) To: Pablo de Lara , john.mcnamara@intel.com, marko.kovacevic@intel.com Cc: dev@dpdk.org References: <1589790958-285679-1-git-send-email-pablo.de.lara.guarch@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <36f91b7b-47c7-fed0-de6d-71fb7e4d6870@redhat.com> Date: Wed, 20 May 2020 11:38:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1589790958-285679-1-git-send-email-pablo.de.lara.guarch@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: add NASM installation steps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18/05/2020 09:35, Pablo de Lara wrote: > The intel-ipsec-mb library requires NASM as a dependency. Hi Pablo, Thanks for the patch. Couple of comments below. Kevin. > Steps on how to get and install NASM are added on the documentation > of the crypto PMDs which requires the library. > Bugzilla ID: 417 > Signed-off-by: Pablo de Lara > --- > doc/guides/cryptodevs/aesni_gcm.rst | 14 ++++++++++++++ > doc/guides/cryptodevs/aesni_mb.rst | 14 ++++++++++++++ > doc/guides/cryptodevs/kasumi.rst | 14 ++++++++++++++ > doc/guides/cryptodevs/snow3g.rst | 14 ++++++++++++++ > doc/guides/cryptodevs/zuc.rst | 14 ++++++++++++++ > 5 files changed, 70 insertions(+) > > diff --git a/doc/guides/cryptodevs/aesni_gcm.rst b/doc/guides/cryptodevs/aesni_gcm.rst > index 7dfd0ca..e4b0e7e 100644 > --- a/doc/guides/cryptodevs/aesni_gcm.rst > +++ b/doc/guides/cryptodevs/aesni_gcm.rst > @@ -50,6 +50,20 @@ can be downloaded in ` make > make install > > +The library requires NASM to be built. Depending on the library version, it might > +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14). > + > +NASM is packaged for different OS. However, on some OS the version is too old, > +so a manual installation is required. In that case, NASM can be downloaded from > +`here `_. Getting some warnings because of the 'here': $ make doc-guides-html sphinx processing guides-html.. /home/ktraynor/code/dpdk/doc/guides/cryptodevs/aesni_gcm.rst:5: WARNING: Duplicate explicit target name: "here". /home/ktraynor/code/dpdk/doc/guides/cryptodevs/aesni_mb.rst:5: WARNING: Duplicate explicit target name: "here". /home/ktraynor/code/dpdk/doc/guides/cryptodevs/kasumi.rst:5: WARNING: Duplicate explicit target name: "here". /home/ktraynor/code/dpdk/doc/guides/cryptodevs/snow3g.rst:5: WARNING: Duplicate explicit target name: "here". /home/ktraynor/code/dpdk/doc/guides/cryptodevs/zuc.rst:5: WARNING: Duplicate explicit target name: "here". > +Once it is downloaded, extract it and follow these steps: > + > +.. code-block:: console > + > + ./configure > + make > + make install > + > .. note:: > > Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53. > diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst > index a2c3a84..9154fb4 100644 > --- a/doc/guides/cryptodevs/aesni_mb.rst > +++ b/doc/guides/cryptodevs/aesni_mb.rst > @@ -75,6 +75,20 @@ can be downloaded from ` make > make install > > +The library requires NASM to be built. Depending on the library version, it might > +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14). > + > +NASM is packaged for different OS. However, on some OS the version is too old, > +so a manual installation is required. In that case, NASM can be downloaded from > +`here `_. > +Once it is downloaded, extract it and follow these steps: > + > +.. code-block:: console > + > + ./configure > + make > + make install > + > .. note:: > > Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53. > diff --git a/doc/guides/cryptodevs/kasumi.rst b/doc/guides/cryptodevs/kasumi.rst > index edbc1c6..4a582a7 100644 > --- a/doc/guides/cryptodevs/kasumi.rst > +++ b/doc/guides/cryptodevs/kasumi.rst > @@ -47,6 +47,20 @@ on their system before building DPDK: > make > make install > > +The library requires NASM to be built. Depending on the library version, it might > +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14). > + > +NASM is packaged for different OS. However, on some OS the version is too old, > +so a manual installation is required. In that case, NASM can be downloaded from > +`here `_. > +Once it is downloaded, extract it and follow these steps: > + > +.. code-block:: console > + > + ./configure > + make > + make install > + > .. note:: > > Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53. > diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst > index b715b46..eedc230 100644 > --- a/doc/guides/cryptodevs/snow3g.rst > +++ b/doc/guides/cryptodevs/snow3g.rst > @@ -46,6 +46,20 @@ on their system before building DPDK: > make > make install > > +The library requires NASM to be built. Depending on the library version, it might > +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14). > + > +NASM is packaged for different OS. However, on some OS the version is too old, > +so a manual installation is required. In that case, NASM can be downloaded from > +`here `_. > +Once it is downloaded, extract it and follow these steps: > + > +.. code-block:: console > + > + ./configure > + make > + make install > + > .. note:: > > Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53. > diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst > index c384f3d..0741e57 100644 > --- a/doc/guides/cryptodevs/zuc.rst > +++ b/doc/guides/cryptodevs/zuc.rst > @@ -46,6 +46,20 @@ on their system before building DPDK: > make > make install > > +The library requires NASM to be built. Depending on the library version, it might > +require a minimum NASM version (e.g. v0.54 requires at least NASM 2.14). > + > +NASM is packaged for different OS. However, on some OS the version is too old, > +so a manual installation is required. In that case, NASM can be downloaded from > +`here `_. > +Once it is downloaded, extract it and follow these steps: > + > +.. code-block:: console > + > + ./configure > + make > + make install > + > .. note:: > > Compilation of the Multi-Buffer library is broken when GCC < 5.0, if library <= v0.53. >