From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C17031B2AA for ; Wed, 17 Jan 2018 23:25:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4703720D41; Wed, 17 Jan 2018 17:25:28 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 17 Jan 2018 17:25:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=joaCpi+VgDVpgvqDYiJEIOe9nW 3jZQWK7Gu9MPXhZPA=; b=Hew4xEvt8Il9y4gMdBROKaEGkQs2s1RJWkU+8j/p/X R1v/m3B/Q7cS3Iqeq85X/B0N5Ov1LV1Yx7um1tj76P8VbhEVqXEmRVUOwLKeqzXl WSM2sk+yU3KqurUHKRIWHnYeaNepq80MBXnnQ4CrBDjoDDvrk9gwaaFdtC8FYvBE M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=joaCpi +VgDVpgvqDYiJEIOe9nW3jZQWK7Gu9MPXhZPA=; b=Rlm8CwGumritssm1LZnJFS u4hYmGSRIqjgmpZdZ3Cg49zmEifq4vAHpA0INEcNOw1jIjhOKA5F57gmxNQZcFgD Zhfcbrdjn/l8w/OIdZ1fCc7sPP8JLiZ5g60aX38eiZ5lxhB/FJ42hXdcs8iwJxIG 9ff93rNUH4SZrenPbP0Kpq+uDQxb7dSyJq0zYJm4BdccW+/L3TOwc/CiS5H+NB3P P76Bu7Az0CyhSplMcxKX0gjVeYw7GbS/YzzUq+wKgOPLjlH/bKOjGZLKmUbA/ksJ 2s4E36rVe8o0cBYE51ukpteNhiiu3lGfVImlVnKVEbTxG/hbxnYQRm0X+diS7XMg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D0C59246F4; Wed, 17 Jan 2018 17:25:27 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Wed, 17 Jan 2018 23:24:55 +0100 Message-ID: <37003992.ckfSjSR6va@xps> In-Reply-To: <20180117215802.90809-4-ferruh.yigit@intel.com> References: <20180109162317.18183-1-ferruh.yigit@intel.com> <20180117215802.90809-1-ferruh.yigit@intel.com> <20180117215802.90809-4-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 4/6] ethdev: separate internal structures into own header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 22:25:29 -0000 17/01/2018 22:58, Ferruh Yigit: > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ SPDX tag requirement spotted :) > +#ifndef _RTE_ETHDEV_COMMON_H_ > +#define _RTE_ETHDEV_COMMON_H_ > +/* > + * Definitions of all functions exported by an Ethernet driver through the > + * the generic structure of type *eth_dev_ops* supplied in the *rte_eth_dev* > + * structure associated with an Ethernet device. > + */ You should explain that it is internal but included by the API functions because of inlining.