DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal: close MP socket during cleanup
Date: Fri, 21 Dec 2018 01:18:30 +0100	[thread overview]
Message-ID: <3702602.Ruh3347ZEi@xps> (raw)
In-Reply-To: <20181220125114.13346-1-qi.z.zhang@intel.com>

20/12/2018 13:51, Qi Zhang:
> When secondary process quit, the mp_socket* file still exist, that
> cause rte_mp_request_sync fail when try to send message on a floating
> socket.
> 
> The patch fix the issue by introduce a function rte_mp_channel_cleanup.
> This function will be called by rte_eal_cleanup and it will close the
> mp socket and delete the mp_socket* file.
> 
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
[...]
> --- a/lib/librte_eal/common/eal_private.h
> +++ b/lib/librte_eal/common/eal_private.h
>  /**
> + * Primary/secondary communication cleanup.
> + */
> +
> +void rte_mp_channel_cleanup(void);

extra blank line above

Applied with minor change, thanks

      reply	other threads:[~2018-12-21  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  7:41 [dpdk-dev] [PATCH] " Qi Zhang
2018-12-19  8:46 ` Thomas Monjalon
2018-12-20 12:30   ` Zhang, Qi Z
2018-12-20 12:51 ` [dpdk-dev] [PATCH v2] " Qi Zhang
2018-12-21  0:18   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3702602.Ruh3347ZEi@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).