From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0EEB9DE3; Fri, 21 Dec 2018 01:18:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8CFF02204C; Thu, 20 Dec 2018 19:18:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 19:18:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=RoHbf0Ihc0/x3e2g/R3K7XDG2vXNCnzrj9YFHz9jTB0=; b=Lf5MUt2NhEAZ 6KWwYk6+2q4FfkmEz7DCtE/OYkopbpILfKv6vbUudF4CFlp8TH+uIXTkWqok+ciN incGOD207GWj0QdfXsBM9yEzqx8MEVhPtYqfnPNLFJholRQ7xJFf/wf79rGQ8+xG dsKcrDri5JngNSMslqZqWRNmbnzhzsM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=RoHbf0Ihc0/x3e2g/R3K7XDG2vXNCnzrj9YFHz9jT B0=; b=wcHGyNCEsmCITHC+vLLIFyZjNQvEQODQHrTXdNQSpCFqNRFb8Kc7btDoI aoLGe6O0aT0hdMp89NdURRpjPaaDlOhuTTWWdwMNI9j1LK1rAZQuiNfiG4QQZbtZ ZSlOQq/nBeH6AUgnVczjzLF8U7lkXFRpJW2SyH1B7f2HNIh7VScVDTH+zkx8w+0w rdyoRyEEeaudlJfX6oOkr4lqCroENm3jOOKbwS8XOXs1QRXkGY7rV0HwkI/JzIZk WznoTcZ1+0RDGhwUM7UaGa5Osc8Fzgc0rsgcsAIcVMyxchexA6ljfl3l9tsl5BhL pvcIXCSCu0n49gzpWVX5SuhYBfk9w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejgedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B18910085; Thu, 20 Dec 2018 19:18:31 -0500 (EST) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, stable@dpdk.org Date: Fri, 21 Dec 2018 01:18:30 +0100 Message-ID: <3702602.Ruh3347ZEi@xps> In-Reply-To: <20181220125114.13346-1-qi.z.zhang@intel.com> References: <20181219074107.10084-1-qi.z.zhang@intel.com> <20181220125114.13346-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: close MP socket during cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 00:18:33 -0000 20/12/2018 13:51, Qi Zhang: > When secondary process quit, the mp_socket* file still exist, that > cause rte_mp_request_sync fail when try to send message on a floating > socket. > > The patch fix the issue by introduce a function rte_mp_channel_cleanup. > This function will be called by rte_eal_cleanup and it will close the > mp socket and delete the mp_socket* file. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang [...] > --- a/lib/librte_eal/common/eal_private.h > +++ b/lib/librte_eal/common/eal_private.h > /** > + * Primary/secondary communication cleanup. > + */ > + > +void rte_mp_channel_cleanup(void); extra blank line above Applied with minor change, thanks