From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A522A04B5; Tue, 27 Oct 2020 17:26:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14C16A9A0; Tue, 27 Oct 2020 17:26:09 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E33759AFD for ; Tue, 27 Oct 2020 17:26:07 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 81CAB5C00D2; Tue, 27 Oct 2020 12:26:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 12:26:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= I1Th/X2EIdEiulH9Q/zpaEEgPNSfUnV6/1IiPOV8nXY=; b=KZ3d0Xouu79LnqSt t+ku4qyerKz73EEMjKRck195gnTDcpDup8W8plZaM3R9c6+21W8BgtlvSbQLp4Dv Wbqg0tuhZ61Dh6oPs0qob5epsvUEV/H0rLy9lQjbpwkH9/6zyD026Dcd4e6qt4DV DZHWSx61uz038ibDzfLeMPk/2rv05XI/RXUrkyYtmEUKQvZja9iYACcL7f5zhIqw 0MwFv1WkM+khmV3KMibE9CJIi904Kh7m97hffWX2USr607yw4zuckangNpkU7ay+ HZKTBWGKj0GubPwE1PQFJku1K4emZegxYXG2fI1Rjrx8XOYVat6X2ohMTRsgc3EW DNI2WA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=I1Th/X2EIdEiulH9Q/zpaEEgPNSfUnV6/1IiPOV8n XY=; b=Uqh1Wtp8Td7sNA9QARydEzkXQS+IgUiT4hTnBwQeKx1FOz6TXZuv5BFu0 yirL/7YvYAxXqxlWSHcHkyVodrii3FFt5JZ6TaV5PrSoRTnlB53vxGksFpCiezbI vlx3Ao8F2SH4J1a6fctqpbmBfsqgjOOUWVZK1QQZ5xiCTEUkG6L34fUlljKmkL/V 2jRG66/Yf0Y5wogp9Jcxu3ZE+HCO6JkuOJn933Fb+AiIi6B0+JyPu42iaZefOsRe 6tvxTLU8Uk/yudqMnZB0tXtA+cS34G1rkhGu19NTzUdojZpWkCZxt1vdg/QepekL 6hlNZGraD9FguWJL0to4ctx8liNZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75D993064683; Tue, 27 Oct 2020 12:26:04 -0400 (EDT) From: Thomas Monjalon To: Nithin Dabilpuram Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Pavan Nikhilesh Date: Tue, 27 Oct 2020 17:26:03 +0100 Message-ID: <3705096.qAGAdPRMt2@thomas> In-Reply-To: References: <20201026052105.1561859-1-thomas@monjalon.net> <6053263.1sEcI2TILj@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 04/15] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 17:16, Nithin Dabilpuram: > On Tue, Oct 27, 2020 at 04:57:16PM +0100, Thomas Monjalon wrote: > > 27/10/2020 16:33, Nithin Dabilpuram: > > > On Tue, Oct 27, 2020 at 03:33:35PM +0100, Thomas Monjalon wrote: > > > > 27/10/2020 15:23, Nithin Dabilpuram: > > > > > On Mon, Oct 26, 2020 at 11:20:02PM +0100, Thomas Monjalon wrote: > > > > > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > > > > > It is moved to a dynamic field in order to allow removal of udata64. > > > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > > --- > > > > > > --- a/lib/librte_node/ip4_lookup.c > > > > > > +++ b/lib/librte_node/ip4_lookup.c > > > > > > +int node_mbuf_priv1_dynfield_offset; > > > > > > + > > > > > > > > > > This change doesn't work in secondary as it is process local memory. > > > > > > > > Yes that's an issue. > > > > Can we copy the value when starting a secondary process? > > > > > > Currently there is no call back which will be called only in secondary. > > > > > > Can you move this value to node->ctx 8'th byte offset ? Node context is of size > > > 16 bytes and should be sufficient. > > > Currently first 8 B of node->ctx is used to store that socket's lpm pointer. > > > > Please would you be able to do such patch? > > Ack, will send a patch on this thread so that you can include in next version. Thanks