From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E64DF2BE1 for ; Wed, 28 Jun 2017 09:44:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3362C20B83; Wed, 28 Jun 2017 03:44:20 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 28 Jun 2017 03:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=PlUlNvI9oYTHvVp CEha77vTap1tHWZFHEmHfRG0OKn4=; b=fKy3jPKOWTEQrHKUEsBHrEsXgQmfdld NFyQqh/91m1d1rV7kOK31eLOvZ17ZITKEKbmxdn77k6Q2nhpL/IRzsigff3A8/bk 1BluYtyo/hDjQuiPv2/Ycr+0HrtFV2zuAarDJBE/L7rFdxZyM8s4Vx8vBCF4iaJW eLQB7tdYdlG4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=PlUlNvI9oYTHvVpCEha77vTap1tHWZFHEmHfRG0OKn4=; b=P1JnLu4r q7OrUzum5TZDxU6PV8X9InQ+9yPyNOFRGBD7oLoSizst2YmC0eaCHVvL+pLCoWur xqqvKjlyhpht1X6cRztNUdfNzloMGt/rr/QtFEubfh8EcgVPuf4ux7po5ugBYldd 0fx7JdpYPpIfD1aqGCGPnM2e9fRaHGxveiJs1BsEVWV8bb2jbtlexxkcalQmEaca 6RXJSQIU/2jtUBWqGX7L1Ef3EKfAQ/stUcQe3+f2DjqWoVfTMtDJ4lSlWaVD0ZVU RmD8Ocd7aFfWAdKheSAfk4V2xbaD/FIfukV8twQY+ErGomjoYOOv1TnekpM20sm8 y+OtsnS4uPC0Qw== X-ME-Sender: X-Sasl-enc: Lx5Ltk4tH1I6ISYBgiUZmFxsio/xUPtmXD2eZzKk881c 1498635859 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D34C97E7B1; Wed, 28 Jun 2017 03:44:19 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Wed, 28 Jun 2017 09:44:18 +0200 Message-ID: <3705717.5YLzOZFs93@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 12/19] devargs: generic device representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 07:44:21 -0000 21/06/2017 01:35, Gaetan Rivet: > Remove the dependency of this subsystem upon bus specific device > representation. > > Devargs only validates that a device declaration is correct and handled > by a bus. The device interpretation is done afterward within the bus. > > Signed-off-by: Gaetan Rivet > --- > app/test-pmd/testpmd.c | 9 ++---- > lib/librte_eal/common/eal_common_devargs.c | 48 +++++------------------------ > lib/librte_eal/common/eal_common_pci.c | 9 ++++-- > lib/librte_eal/common/eal_common_vdev.c | 17 +++++----- > lib/librte_eal/common/include/rte_devargs.h | 16 ++-------- > lib/librte_eal/common/include/rte_vdev.h | 2 +- > test/test/test_devargs.c | 9 ++---- > 7 files changed, 30 insertions(+), 80 deletions(-) Is it correct to add this change when rebasing? --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -533,7 +533,7 @@ pci_plug(struct rte_devargs *da) struct rte_pci_device *pdev; struct rte_pci_addr *addr; - addr = &da->pci.addr; + da->bus->parse(da->name, &addr); /* * Update eventual pci device in global list. * Insert it if none was found.