From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
Isaac Boukris <iboukris@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] dumpcap: correctly disable promiscuous mode at exit
Date: Mon, 18 Mar 2024 04:04:05 +0100 [thread overview]
Message-ID: <3705843.RUnXabflUD@thomas> (raw)
In-Reply-To: <CAC-fF8RyUwvrB+qUGYSPc-TJ899r=ScMfoxifYrd46qd9Wp8KQ@mail.gmail.com>
08/03/2024 08:09, Isaac Boukris:
> On Fri, Mar 8, 2024 at 12:39 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > From: Isaac Boukris <iboukris@gmail.com>
> >
> > If request to set promiscious mode failed at startup,
> > then it is not necessary to disable it when shutting down.
> >
> > This should only be issue if with a buggy driver because if
> > driver does not support setting promiscious it would just
> > ignore request to disable it as well.
> >
> > Fixes: 6026bfae07d4 ("app/dumpcap: support multiple interfaces")
> > Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> V2 looks good to me.
>
> Thanks!
Applied, thanks.
prev parent reply other threads:[~2024-03-18 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:23 [PATCH] " Isaac Boukris
2024-02-27 18:07 ` Stephen Hemminger
2024-03-06 21:45 ` Thomas Monjalon
2024-03-07 22:37 ` [PATCH v2] " Stephen Hemminger
2024-03-08 7:09 ` Isaac Boukris
2024-03-18 3:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3705843.RUnXabflUD@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=iboukris@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).