From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9716C43CDD; Mon, 18 Mar 2024 04:04:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24580402BF; Mon, 18 Mar 2024 04:04:11 +0100 (CET) Received: from wfout5-smtp.messagingengine.com (wfout5-smtp.messagingengine.com [64.147.123.148]) by mails.dpdk.org (Postfix) with ESMTP id 9DFFE40289 for ; Mon, 18 Mar 2024 04:04:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 17D081C000A6; Sun, 17 Mar 2024 23:04:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 17 Mar 2024 23:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1710731047; x=1710817447; bh=WGDJfZBHZBdd8QdrVaa8mdkq/9LTiBLIcHW/4YNmZyA=; b= n/ATbaEWUMdg4Nu5Vn/OzKFE9OQrTpomFIQQcbDucFxYq05OvIXMWow/oF72e5P0 /DPTbjsG6B8uj4YeH94jOrHN5QEYyRQvJS+c6dNC1BiTwgzgJT3K5t+eLb5eCUBy NFQSj/dRyPHPIHzPYJwI8s1YNgcfEd3GEH89R/hrxCz9LU9tnQjq7/JXeWGG4iPf gH7ycL64nnCxY0ggoe0CHV6/1F+J2JxFrNk+FB9Av3fjGvFwvD0iUcAOxKtZP47c kMhuZRZlulK72bfcI0auF/uH6ReOPGEYnuGQxc3nXzqgn13APadIKlO2L/kIuU8J GFXdvMpZaywH8seEC5SNKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1710731047; x= 1710817447; bh=WGDJfZBHZBdd8QdrVaa8mdkq/9LTiBLIcHW/4YNmZyA=; b=g 3pwfjY5YmZ1U517m5evsozPtkNNr9cmE8gv5nNGt5OO0F3ODSHe0+KnMqjrFnuB0 EM75DqOTlmj4IhrTuCmb/OreG+e/roQ6mhjAbhFLaBVGxGZz3vxuMEaIuUuo0x2R DglGtTyKE6DcAvRG+xim7Ii73J9MI1VYhO9HCqPLQWbjOckRJ2recyyiuk6xZMnm WBotfRtzLxI2IAEQlQlInJaZehR/7eujzXkZy1KHZm2hhObNa2218+BOa7iZ4J2w En8KxoSAmoKyLOeCfY+PatO9cPInPSgiRy/0auNQFQu0Rc/LtYrTylLPGBHYfi3x s8mxerlMqXxqgRr0++x7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrkeeigdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Mar 2024 23:04:06 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Isaac Boukris Cc: dev@dpdk.org Subject: Re: [PATCH v2] dumpcap: correctly disable promiscuous mode at exit Date: Mon, 18 Mar 2024 04:04:05 +0100 Message-ID: <3705843.RUnXabflUD@thomas> In-Reply-To: References: <20240227092326.340229-1-iboukris@gmail.com> <20240307223851.5786-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/03/2024 08:09, Isaac Boukris: > On Fri, Mar 8, 2024 at 12:39=E2=80=AFAM Stephen Hemminger > wrote: > > > > From: Isaac Boukris > > > > If request to set promiscious mode failed at startup, > > then it is not necessary to disable it when shutting down. > > > > This should only be issue if with a buggy driver because if > > driver does not support setting promiscious it would just > > ignore request to disable it as well. > > > > Fixes: 6026bfae07d4 ("app/dumpcap: support multiple interfaces") > > Signed-off-by: Isaac Boukris > > Signed-off-by: Stephen Hemminger >=20 > V2 looks good to me. >=20 > Thanks! Applied, thanks.