From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 826CC42360; Wed, 11 Oct 2023 12:20:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E47340279; Wed, 11 Oct 2023 12:20:49 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C561C40266 for ; Wed, 11 Oct 2023 12:20:47 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AAD785C013B; Wed, 11 Oct 2023 06:20:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 11 Oct 2023 06:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697019644; x=1697106044; bh=7K0Ac/pzopbnvzc8NfSTaC9fx8N5nIpH/bH glTg02sE=; b=hIMU4MAHe1tidCSN1VKhQaJ3H1PU5YsZSmt1XCLSBDE7KxkZGrZ F87BR6/YeDQdLaDLKSZbGK0RsepEF73Qu8XnWexJXx0tsEK3oyw9XfUHqyvhwNyr Y+rw+Tk94izp8Jwy+1lt6YScDKfJXaUboF8UZBU7Msd85bF/AgdlI+wtAJHvnsvv B1GD6XF4DKJwaXiDcTOplDTbH5mhqfyZepG0Bf8sp3LlpVcQzwcHryodp7nHk0DQ Ko88S2M+0RsCIaPJsqzHwqpl49oRA36Ad/LjgdI5G0K/P68RtNftSg4Mkx0bYbOe pj+Kop98/Oop/anACjJ3hZxAUZUMOiN6VAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697019644; x=1697106044; bh=7K0Ac/pzopbnvzc8NfSTaC9fx8N5nIpH/bH glTg02sE=; b=X32NZSuDeyUiaoafxpbquyjtYM/phPLatU1aJ+R7+0+i2juevjV BtdJ/SXNClTzz3fesUVetSRuY8a6DX6L3PkMeK46TIUGR1tioYInN80BDfOWkRLd zQ7b2yv+UOSDTn+3sa6Myh49VV/2dIFllzlhA2GHXET63+U9OXt+6YU+Rk0KENev U7vc35rDRwhY5cazWTVw+FO/U83TFt4TbBeen+BvuXAum0tAAU+pKPTGnfctSGrP 0wDu/IBr71GQJHan0KbUGIpjCE8W0whT51rKnv1ItlWg4EqAi30+lbqYGUPVhn9A pzPrgt5uj8TqLacsSANeYNg9Qe8/kbUpc7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheekgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Oct 2023 06:20:43 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , David Marchand , dev@dpdk.org Subject: Re: [PATCH] doc: remove confusing command to send patch Date: Wed, 11 Oct 2023 12:20:41 +0200 Message-ID: <3707040.MHq7AAxBmi@thomas> In-Reply-To: <39af1d9d-e00d-4f61-b6e7-87490eb8e47f@amd.com> References: <20231010162635.755975-1-thomas@monjalon.net> <39af1d9d-e00d-4f61-b6e7-87490eb8e47f@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/10/2023 10:41, Ferruh Yigit: > On 10/11/2023 9:30 AM, Bruce Richardson wrote: > > On Wed, Oct 11, 2023 at 10:03:07AM +0200, Thomas Monjalon wrote: > >> 11/10/2023 09:30, David Marchand: > >>> On Tue, Oct 10, 2023 at 6:26=E2=80=AFPM Thomas Monjalon wrote: > >>>> > >>>> In the contributor guide, it was said that no need to Cc maintainers > >>>> for new additions, probably for new directories not having a maintai= ner. > >>>> There is no harm, and it is a good habit, to always Cc maintainers. > >>>> > >>>> Remove this case as it can mislead to not Cc maintainers when needed. > >>>> > >>>> Signed-off-by: Thomas Monjalon > >>> > >>> I agree Cc: maintainers should be the default / recommended way of > >>> sending patches. > >>> > >>> Just to convince myself, adding some meson skeleton for a "plop" > >>> library, adding an entry in the release notes and hooking in > >>> lib/meson.build: > >>> $ git show --stat > >>> doc/guides/rel_notes/release_23_11.rst | 4 ++++ > >>> lib/meson.build | 1 + > >>> lib/plop/meson.build | 2 ++ > >>> > >>> $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch > >>> > >>> In this case, it translates to an empty To: list if you follow the > >>> example command line: > >>> git send-email --to-cmd ./devtools/get-maintainer.sh --cc > >>> dev@dpdk.org 000*.patch > >>> > >>> We could add a default list of recipients if no maintainer is found by > >>> the script. > >>> And the next question is who should be in that list.. > >> > >> Or we can send to dev@dpdk.org, Cc maintainers. > >> This is what I do: > >> git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh > >> > > +1 for this, mainly on the basis of it being what I do too! :-) > > >=20 > I am for "--to-cmd=3D./devtools/get-maintainer.sh --cc dev@dpdk.org" >=20 > To highlight response is expected from the maintainers, and community is > informed. >=20 > Also people may have filters to give higher priority to emails they are > in 'to' list, high priority is what we want from maintainers :) They should give high priority when they are Cc as well. The problem is that we may have patches with empty "To", especially for cover letters and new libs.