From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ECA9A04FD; Wed, 15 Jan 2020 00:19:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD9791BFE4; Wed, 15 Jan 2020 00:19:34 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3ACA41BFDD for ; Wed, 15 Jan 2020 00:19:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 76FD921F82; Tue, 14 Jan 2020 18:19:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 14 Jan 2020 18:19:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rT7OPusGsmpVLAZUYjgHIZfOn0KhJfMdMKw/4FFPW+4=; b=pZ8+zNRSqGN+ wLZk5+fLtJTDgl8OftQyz40cyN4WwYLIECGDjNfvZpEBUhqlLHIbEkjVSeWWYqie st3ZZvbqKUYCltpMwlTIAESoUqlEF2ufIckyelaXTgW7jI3Cb7fNRIdvA0RGRQt3 2Sbou0bwifyoQvtE5POm9DWkhAvch0A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rT7OPusGsmpVLAZUYjgHIZfOn0KhJfMdMKw/4FFPW +4=; b=qm5CltoHM7qbtDaXTwwKYxoLUNU6EH75Y7NKu8T5anZWIBHzN1Sn9fvPQ Kr68R9cb1lXSkKbCOHjNVLsLGBSiaAEfGrwsU6Kp3NDM+mJPxokZdlYKnuIqSCUo LhbtxxNzGxDohWf1V8y7uddnnUXDaB+CybX7hJRkbzmvxn7AXbNg6WTwXXURDFU7 7GBp0h6Tv7cL9OG7UK9Hb/PnQduqA8+Au+NfyPNNYA83uA9pj0roP+CgUVM2LxgZ CVobLezZTY2lsgmMhSgEZ1CA4s7EzmqfCmIg0H1mFs3xx6Xp0paJgmYsAF6B2uRC i+/ivx5wi4iiYHeVHrvVXDZWUxqlw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrtddvgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E86D330602DB; Tue, 14 Jan 2020 18:19:31 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: "Richardson, Bruce" , "dev@dpdk.org" , "Laatz, Kevin" , "aconole@redhat.com" , "nhorman@tuxdriver.com" , Michael Santana , "Mcnamara, John" , "Kovacevic, Marko" , "Kinsella, Ray" Date: Wed, 15 Jan 2020 00:19:30 +0100 Message-ID: <3707731.e99z0qppnp@xps> In-Reply-To: References: <20191220152058.10739-1-david.marchand@redhat.com> <59AF69C657FD0841A61C55336867B5B07EEAB0AE@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/12/2019 17:20, Kinsella, Ray: > From: Richardson, Bruce > > From: David Marchand > > > +Checking ABI compatibility > > > +-------------------------- > > > + > > > +The first thing is to build reference binaries for the latest > > release > > > +your patches are built on top of. > > > + > > > +Either you are in a git tree and an easy way to identify this is to > > run:: > > > + > > > + git checkout $(git describe --abbrev=0) > > > + > > > +Or you use a tarball and you extract the sources in a director of > > > +your > > > choice. > > > + > > > +Next is building those sources, refer to the previous paragraph. > > > +You can set ``DPDK_BUILD_TEST_DIR=reference``, so that the builds > > > +occur in this directory. > > > + > > > +Finally, the ABI dump files are generated with the > > > +``devtools/gen-abi-reference.sh`` script. This script will look for > > > +builds in the current sub directory ``reference``. But you can set > > > +the environment variable ``DPDK_ABI_REF_BUILD_DIR`` to a different > > location. > > > + > > > +Once done, you can check your current binaries ABI with this > > > +reference with the ``devtools/check-abi-reference.sh`` script. > > > > > > > I still very much dislike forcing the user to generate his own > > reference version to compare the ABI against. These should be archived > > and the user should just be able to pull them down via git or http or > > otherwise. Two reasons for this: > > > > 1. Less error prone, since there is no chance of the user having an > > incorrect build for whatever reason. > > > > 2. Less effort for the user than asking them to do extra builds. The > > more steps the user has to follow, the less likely they are to attempt > > the process. > > +1 ... 100% agree with this. > > Many people won't know or understand what the reference is, > or why they to generate it. I don't want to generate and save the reference in git for each arch. We can make reference build more automatic with a command like this: git clone --branch v19.11 . $DPDK_BUILD_TEST_DIR/abiref-19.11 Also I don't like mixing build and check steps. I believe the compilation should be simple and right to the point. This approach, from David, does not prevent from saving the dumps later if we really feel a strong need. That's why I suggest going with this patch.