From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FCEA43206; Thu, 26 Oct 2023 10:53:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE40E402CE; Thu, 26 Oct 2023 10:53:30 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 442B8402C5 for ; Thu, 26 Oct 2023 10:53:29 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 19DB15C02DA; Thu, 26 Oct 2023 04:53:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 26 Oct 2023 04:53:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698310406; x=1698396806; bh=TPqsjfgvDIPj8PDjWLrqmvXy3DSva0r5Mgc ZBffm6D8=; b=NeOqOGsUoPpKYuUUqcwplafasdLisyqZopaTV4X/E3pTHbnD7/8 BC5wGv5m8BKvmWjJHFlVvF8dGjCjKrzSRCZ0JxwYOBmqQgAJ44mtPwGDgIyavMcO Vx2G+lnwzsBopX/0VcOhU2n77up8ibfv46ANZOFf3e4Z1RrQkxQzH7alZDsldCgf BcKTRTigB5BlCIOc3lgf82JwCWMU4R8eD6jrdDGV5ABikJIn/lYnaFXDnOqYjWMA RzTxcK5aHX6PgiIE2r34hh1ERjWF5RromC0xFXYlMK4GSZC2+F4ZcpnUMHBxORaj 4LWGhOlcfanPpDU09hcE0Pf6hZ/9+ISdMug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698310406; x=1698396806; bh=TPqsjfgvDIPj8PDjWLrqmvXy3DSva0r5Mgc ZBffm6D8=; b=NNa5ID6mDqGTdtfzhFMfHWbkNwxuJLJcnglSnGJfVJChuYxfKnk Ff54F/crXfcP4ERcOYpuB85z762Sahmh3L4zeVc2lHanvyazX2XCEQbsP8foAcn8 vzELiVxJczFRwRuc/ihcGvgeiZMo7/EwrlvJU/or+P9QAPSTI/wx2wQQld5Yyy97 n4dkPG7/hALsJUfmHLMNmuNwnZWwtTPvf87T1mkH8W6sDFwA2wTorvJ/FiU0Lh/d kLMUXhx54Tf8tyis3Q5RJVCCHqmdiaOyPrXXbT2ZUPKmCOKoDbUw77yGH4sq9Nqk OB1S8wGjkniNKpjpY4iNn8OnoUvGNRSwl6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 Oct 2023 04:53:24 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Jie Hai , "lihuisong (C)" Cc: dev@dpdk.org, fengchengwen@huawei.com, liudongdong3@huawei.com, stephen@networkplumber.org Subject: Re: [PATCH v5 00/40] support setting and querying RSS algorithms Date: Thu, 26 Oct 2023 10:53:21 +0200 Message-ID: <3709832.MHq7AAxBmi@thomas> In-Reply-To: References: <20230908080030.3837515-1-haijie1@huawei.com> <2c1c2b20-f7ab-4189-8f04-746edf19f1b4@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/10/2023 14:57, lihuisong (C): > =E5=9C=A8 2023/10/17 22:26, Ferruh Yigit =E5=86=99=E9=81=93: > > On 10/17/2023 3:06 PM, Thomas Monjalon wrote: > >> 11/10/2023 11:27, Jie Hai: > >>> 55 files changed, 395 insertions(+), 106 deletions(-) > >>=20 > >> Changing all drivers is suspicious. > >> It shows that something is missing in ethdev. > >> Please can you add the checks in ethdev only? > >> > > That is kind of request from me, let me try to summarize what is going = on, > > > > there is a new config item added to "struct rte_eth_rss_conf" introduced > > in this set, which is RSS hashing algorithm to use. > > > > Problem is none of the existing drivers are taking account this new > > config item, so application will request it but drivers silently ignore= it. > > > > This is a generic problem when adding a new config item to existing > > config struct. > > > > So my request was if drivers not supporting it, and it is requested by > > the application, driver should return an error to let application know > > that it is not supported, that is why bunch of drivers updated. > > > > > > One option can be adding a new, specific API and dev_ops for this, for > > this case new config item is related to the existing RSS API, so I think > > it can be part of the existing API. > > > > Other can be to have some kind of capability reporting by drivers, and > > application will detect it and won't request this new config item, I > > think Stephen already suggested something like this. This capability > > flag is again a generic requirement, and `rte_eth_dev_info_get()` > > partially used for this purpose. I think it will be odd from application > > perspective to have a capability for just one config item of a feature = set. > > > > > > Anyway, I think updating drivers to report they are not supporting new > > config item is best option to me, but also I think we should discuss > > this capability reporting in ethdev in a wider context. > IMO, it is more better to report RSS algorithm capability. > It can avoid the later ABI break successfully as Stephen said. Yes we should add a capability for RSS algorithm.