From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B03E4A0559; Mon, 16 Mar 2020 12:14:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8952E25D9; Mon, 16 Mar 2020 12:14:57 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id CBE7FCF3 for ; Mon, 16 Mar 2020 12:14:55 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1B14D5C032C; Mon, 16 Mar 2020 07:14:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 16 Mar 2020 07:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1e6oJXEe84AW9LSOZtMQVE3x12Jr3lOO670Q9FQT7qQ=; b=RpNKd9bb3ZZ8 aUqfTpky2evEdP0PG03Q/hm6NcRCJavZ/7yf6Il3TNGGC/0i9QskxrSfa9qDmnay Rnyd8DSa7NYd2ojrG3kGhlFLEQaPbxcA8qfKQdqeFHxpOcw1L4MbeX50hgisi6Ad qgWuHlYL8DsButq7yMge673SRsHSZuI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1e6oJXEe84AW9LSOZtMQVE3x12Jr3lOO670Q9FQT7 qQ=; b=iCtsfOfkBYifWiOKx8Du3jQpHC+b1RzIB8KXf4S6v4anP682IGTAiC3Mu N6hqqJtmYcBVUgEYp6KLVnAhyiXNMoNh0IDkWF+7LGmr2xLPepmBWL+du1T2Jrwy TGxD+jS+awPPOFPo0/lr1w0UAWDJ8WEEMZpY01xtibNr2JZgaOIMbLx9/r4B6sb5 3T4xBBncfIPmmf70P/3+TlyJYozRXiIuxlRzZdyqGCwHQ1nhtdjx5ol5Ln/KO+nP zNXcUs9onQkXfUHaXLyXStiXxdFFBoF2L+fZrRIFpJjRjRhE+PwaQPxB1GGrEiH0 WzeYC6PY8xs7n+8YV/tlA1q/488OQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 244773280059; Mon, 16 Mar 2020 07:14:53 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Dmitry Kozlyuk , dev@dpdk.org, Olivier Matz Date: Mon, 16 Mar 2020 12:14:51 +0100 Message-ID: <3711538.2iPT33SAM4@xps> In-Reply-To: <20200316110231.GB1953@bricha3-MOBL.ger.corp.intel.com> References: <20200218000229.86621-1-dmitry.kozliuk@gmail.com> <20200316105409.GA1953@bricha3-MOBL.ger.corp.intel.com> <20200316110231.GB1953@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/03/2020 12:02, Bruce Richardson: > On Mon, Mar 16, 2020 at 10:54:09AM +0000, Bruce Richardson wrote: > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > I suggest this change (I can send a patch fixing the issue in other .h files): > > > > > > > > > > +/* > > > > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > > > > + * while a host application (like pmdinfogen) may have another compiler. > > > > > + * RTE_CC_IS_GNU is true if the file is compiled with GCC, > > > > > + * no matter it is a target or host application. > > > > > + */ > > > > > +#if defined __GNUC__ && !defined __clang__ && !defined __INTEL_COMPILER > > > > > +#define RTE_CC_IS_GNU > > > > > +#endif > > > > > + > > > > > +#ifdef RTE_CC_IS_GNU > > > > > -/** Define GCC_VERSION **/ > > > > > -#ifdef RTE_TOOLCHAIN_GCC > > > > > #define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + \ > > > > > __GNUC_PATCHLEVEL__) > > > > > #endif > > > > > @@ -96,7 +105,7 @@ typedef uint16_t unaligned_uint16_t; > > > > > * even if the underlying stdio implementation is ANSI-compliant, > > > > > * so this must be overridden. > > > > > */ > > > > > -#if defined(RTE_TOOLCHAIN_GCC) > > > > > +#ifdef RTE_CC_IS_GNU > > > > > #define __rte_format_printf(format_index, first_arg) \ > > > > > __attribute__((format(gnu_printf, format_index, first_arg))) > > > > > #else > > > > > > > > The code you propose LGTM itself. If you think it's a better solution than > > > > the one proposed below, I see no problem going with it. > > > > > > > > What I wonder is whether pmdinfogen should include the problematic code in the > > > > first place. The errors come from declarations in rte_debug.h, but pmdinfogen > > > > really can't use them, because definitions are compiled for different > > > > machine. Pmdinfogen pulls rte_debug.h via rte_pci.h, which is only needed for > > > > struct rte_pci_id. Shouldn't we instead break this bogus dependency chain by > > > > moving struct rte_pci_id to a separate header? > > > > > > Splitting headers to avoid EAL dependency looks to be a bad precedent to me. > > > > > > > Rather than splitting, we can still fix this by breaking the dependency by > > just not having rte_debug.h included in rte_pci.h. From what I see, there > > is no need for that include to be there, and DPDK pretty much compiles fine > > with it removed - the only other change I had to make was add an extra > > include into mlx5_common.h to compensate for it not getting pulled in via > > rte_pci.h. > > > > And by adding rte_interrupts.h to drivers/bus/ifpga/rte_bus_ifpga.h we can > remove the following headers from rte_pci.h also: > > stdio.h > errno.h > stdint.h > rte_interrupts.h > > This means that we go from 9 includes in the file (including rte_debug.h) to > just 4. Thank you Bruce Are you sending the patch or you prefer I do it?