From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2441BA04C0; Mon, 28 Sep 2020 22:57:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 113CA1D695; Mon, 28 Sep 2020 22:57:50 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id EABD21D68F for ; Mon, 28 Sep 2020 22:57:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 3E02358073F; Mon, 28 Sep 2020 16:57:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 28 Sep 2020 16:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= pJrwAI/sqYL5QEr33FQofZs/NDMf2YZDBAEn0pLrfrs=; b=VOr88ggcQGbZj4GZ 7JdcNJvFDFsN27zWPHZalMILK7yTsTn9ObT1BmWRTXS5QOmLcZhQM0LzkyYgC+02 uaDZheqO7n7K9kAzqG/WYL0VnG8LVMHqwlAsWH2kqpGKU/ipLXAuBk87EfXM994/ 0qCJ8YRO7iVffdV6BqVrlBTW9M0mUqd2dcGF4q2I6EUlVaTMH4PVcIyI0NLCn2Ak Eh67fJ1KgypCR5KVKaVS0IDGgZHKyTGXj2+Vc5h0IswUGprxm6EMZhKT8o3I5ZNC U52kGNnBx1PJxN36/dAdIrYe2tSyvmYXGvdM4TKxy8xozXXukp5ZLQisZUCOjTXP AiiHMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=pJrwAI/sqYL5QEr33FQofZs/NDMf2YZDBAEn0pLrf rs=; b=tPOXDMMaIrqGRu9OpDt0U0gXF3fjVMV7quZs9bq1LI/pNoXZ56ff78cce kb8PE5JdXhlxUP4t3XHaVyFB+utG9rSu1zjZM4ZGZ1spbRlPbKJM5QSJOlj7QqTW WNnyoArz1VwSDs2EvIt3UR8CTijYCX0bC5qpzy381aeeizLrAQQApAoW3UYoOvcI 12R3llBsDtAmT9OnxnZkwXZ4Ue0p5cYQV4nai1U4vFebkYdyZd0jUkT2bFbYirx9 gTr4P422QQnqWauITH6LgIDY93y8CDvaX2v7+jHQcZEDphwOzml8YPvtDwF06q9V cuYuToCz9cDkZFYQovArYcns50qIg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 025F33064674; Mon, 28 Sep 2020 16:57:37 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Steven Webster , Matt Peters , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Akhil Goyal , Jerin Jacob , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang , Anatoly Burakov Date: Mon, 28 Sep 2020 22:57:36 +0200 Message-ID: <37153900.ugnhaSQfCk@thomas> In-Reply-To: <20200928115139.5515d668@hermes.local> References: <20200913220711.3768597-1-thomas@monjalon.net> <20200927234249.3198780-20-thomas@monjalon.net> <20200928115139.5515d668@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/09/2020 20:51, Stephen Hemminger: > On Mon, 28 Sep 2020 01:42:43 +0200 > Thomas Monjalon wrote: > > > The secondary processes are not allowed to release shared resources. > > Only process-private ressources should be freed in a secondary process. > > Most of the time, there is no process-private ressource, > > so the close operation is just forbidden in a secondary process. > > > > After adding proper check in the port close functions, > > some redundant checks in the device remove functions are dropped. > > > > Signed-off-by: Thomas Monjalon > > Since this is a common issue across many drivers, my preference would be that the > check should be in common code of eth_dev_close. It looks like only a few drivers > would allow close from secondary, and that would not be that helpful to a user. It needs to be managed in the PMD to free secondary process resources.