From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 946CA45D79; Fri, 22 Nov 2024 02:43:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 669E343252; Fri, 22 Nov 2024 02:43:02 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id D547E42FA3 for ; Fri, 22 Nov 2024 02:43:00 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Xvd8M223Yz1V4jf; Fri, 22 Nov 2024 09:40:19 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id A468B1800DE; Fri, 22 Nov 2024 09:42:59 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 22 Nov 2024 09:42:59 +0800 Message-ID: <371d6aa8-6273-4f05-86dc-26404dc05e4d@huawei.com> Date: Fri, 22 Nov 2024 09:42:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 06/21] hash/thash: remove use of VLAs for Windows built To: Andre Muezerie , CC: Konstantin Ananyev References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732225298-10322-1-git-send-email-andremue@linux.microsoft.com> <1732225298-10322-7-git-send-email-andremue@linux.microsoft.com> Content-Language: en-US From: fengchengwen In-Reply-To: <1732225298-10322-7-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/11/22 5:41, Andre Muezerie wrote: > From: Konstantin Ananyev > > 1) ./lib/hash/rte_thash.c:774:9 > : warning: ISO C90 forbids variable length array ‘tmp_tuple’ > > The tuple can exceed sizeof(union rte_thash_tuple), for example if any > tunneling header is used in the RSS hash calculation. > > The longest RSS hash key currently supported is 52 bytes. Technically, the > longest tuple with such a key should be (52 - sizeof(uint32_t)), so this > can be used as a size of the tmp_tuple array. > > Signed-off-by: Konstantin Ananyev > --- > lib/hash/rte_thash.c | 2 +- > lib/hash/rte_thash.h | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c > index 336c228e64..fa78787143 100644 > --- a/lib/hash/rte_thash.c > +++ b/lib/hash/rte_thash.c > @@ -761,7 +761,7 @@ rte_thash_adjust_tuple(struct rte_thash_ctx *ctx, > uint32_t desired_value, unsigned int attempts, > rte_thash_check_tuple_t fn, void *userdata) > { This API support parameter check, how about add tuple_len > RTE_THASH_TUPLE_LEN_MAX ? > - uint32_t tmp_tuple[tuple_len / sizeof(uint32_t)]; > + uint32_t tmp_tuple[RTE_THASH_TUPLE_LEN_MAX]; > unsigned int i, j, ret = 0; > uint32_t hash, adj_bits; > const uint8_t *hash_key; > diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h > index c0af5968df..04f9f1875c 100644 > --- a/lib/hash/rte_thash.h > +++ b/lib/hash/rte_thash.h > @@ -121,6 +121,13 @@ __rte_internal > uint32_t > thash_get_rand_poly(uint32_t poly_degree); > > +/** > + * Longest RSS hash key currently supported > + */ > +#define RTE_THASH_KEY_LEN_MAX 52 > + > +#define RTE_THASH_TUPLE_LEN_MAX (RTE_THASH_KEY_LEN_MAX - sizeof(uint32_t)) > + > /** > * Prepare special converted key to use with rte_softrss_be() > * @param orig