From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64901A0526; Tue, 21 Jul 2020 14:10:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B3691BFFF; Tue, 21 Jul 2020 14:10:13 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B24571BFE7 for ; Tue, 21 Jul 2020 14:10:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B0C645C0183; Tue, 21 Jul 2020 08:10:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 21 Jul 2020 08:10:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ETizTKT+bfbcDuvvLvKoCv+ZVNBHpbteLJYOAKnU2mo=; b=T7o1LYbt1wI6IMPB mBQeE0EqPi5DDHNwQoCGSL/HtDbdgaF8L68hDwleB8nv82svjU6UFMoNTlbsYmwr WXnAplARoy9MG8D5juEjWVt0xyZelhg3nnCYTkF60qkU26xotBeUzWmS0skRX6rh cCgqMdsNbpSpiMRh44HHCcmVGcnZnD3r5EsVW1DjtQuLuH1LLgtv1ojGnHscVDUb Yg+EdbqLEWFm93j3/uTpZfjSpM37YpBmNiTElJw3k+FvIurjDKxaxUepglr7s27F 9okA6HKwDUqU1SvbsbnGDEJoxZsrwKmzKn6y509okuJr2waZfEd4YqhtprePgXTx EvNR9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ETizTKT+bfbcDuvvLvKoCv+ZVNBHpbteLJYOAKnU2 mo=; b=B6umRHKz6qcmU6ymDGWLxXT6bYkX07SJdS1vXYDNeQ0JKRJSsg2IyBcuM wXNtUktSbSJXbZasXwClv1tXNG0d81WQPZdJdA4L9ocuPWXYXXfEYErVpbW8OAvy 4fA0fQ/e99Xqysb6VAuTpPDr/x5QTtJqkjWivB/nHWkg5z1NcpP9VqNc3fT5DYgX /yCm3oK87JzwrPrFEqI3TzbUA58bAKLuTEyIHVIA22HC7Y+UtVT+KDpahuQT0aF3 BkIx9LUadGYvKeJqrlEw1RSDbSJHL5Hu851hQWY2XpQFUrXOgEL8RZQdIVChS7VY MPPX6FFIMFliPcAzV1z/GJPA3K+WA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeigdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CA353280067; Tue, 21 Jul 2020 08:10:06 -0400 (EDT) From: Thomas Monjalon To: Parav Pandit , dev@dpdk.org, Matan Azrad , David Marchand Cc: Ori Kam , Ferruh Yigit , dev , Gaetan Rivet , Raslan Darawsheh , Joyce Kong Date: Tue, 21 Jul 2020 14:10:01 +0200 Message-ID: <3721034.pVhDaRLZDH@thomas> In-Reply-To: References: <20200610171728.89-2-parav@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/07/2020 13:29, David Marchand: > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit wrote: > > Basically mlx5_pci_bus, mlx5_net and mlx5_vdpa will be called with same > > priority RTE_PRIO_LAST. > > driver id table and drv_flags dynamically updated as PMDs register. > > > > Should we have another API after rte_pci_register() to indicate that > > some field of the driver are updated, instead of just silently updating > > it in a PMD? > > All of this happens in constructor context, this is a really early > stage used to resolve code dependencies. > No big init should happen there. In general, there is a misunderstanding of what should be done in a constructor. I think we should document constructor usage properly. For the record, init done in constructors should be small. If the application is linked with DPDK but choose to not initialize it, it should not have driver initialized (until it calls rte_eal_init). Constructor init should be limited to adding a driver struct to a list.