From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, bluca@debian.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] compat: fix symbol version support with meson
Date: Mon, 17 Sep 2018 10:42:24 +0200 [thread overview]
Message-ID: <3722786.uIPfu17pdJ@xps> (raw)
In-Reply-To: <20180917081800.8912-1-bruce.richardson@intel.com>
17/09/2018 10:18, Bruce Richardson:
> For meson builds, the define to enable the symbol version
> macros in rte_compat.h was missing. This led to symbols being
> omitted from shared objects. For example, checking rte_distributor.so
> with objdump and comparing make and meson built versions:
>
> $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush
> 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush
> $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
>
> Adding in the missing define fixes this.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
>
> CC: stable@dpdk.org
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
prev parent reply other threads:[~2018-09-17 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:07 [dpdk-dev] [PATCH] " Bruce Richardson
2018-08-30 17:31 ` Luca Boccassi
2018-09-16 9:14 ` Thomas Monjalon
2018-09-17 8:17 ` Bruce Richardson
2018-09-17 8:18 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2018-09-17 8:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3722786.uIPfu17pdJ@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).