From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61410A054F; Tue, 18 Feb 2020 10:47:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 357661D8D9; Tue, 18 Feb 2020 10:47:10 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9E6831D8CC for ; Tue, 18 Feb 2020 10:47:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1E24421A09; Tue, 18 Feb 2020 04:47:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 18 Feb 2020 04:47:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rNQxtl0SBjzAZ3iAv0idI3DswDTTU7/TW7ZJJCQBzrE=; b=bJp/vkKEu6SB OQAgVWgGGSAwHFI5WnXWeX4DMu79+XyYQIpAoeU1hV+5BkWk79dCJJbJGi/9LaJI pUr8Gc9p48pXQCypxLc1/mNs5doEaFdy4zAtD9T9qZnwFPU7DcTalOSte5qyZEvD sCtqWZFzMuyDee6VcEjKULlWS9Dpc9Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rNQxtl0SBjzAZ3iAv0idI3DswDTTU7/TW7ZJJCQBz rE=; b=Carycx/GfiyT29MX2YBu6iZz+RW98pLvIKdjMsV/7Dl0K1zhyn6cHzP21 cApZjVSSB1S2z15Atc+FZd5ZQETpwgwChzX4TboniYPbxMYBzzwyNTuUXbJvKWfg Gf/iayplXdQqRlV6QXKaZOzDLEC8Axkl7JlOzNa+gxEAdeIQkXnvIDWtyixDcH6k UaLM+nv8Ndn7bJzSous+a8+1U4A7d4Tl2ub7d2jumZgPFqBe2C7Dqal/JXztgZDw A1tq+crS5u23K02A7qhWAqku43ULD4dcYZZOy5872rheFdVkf2ctEavjjkfGt2cB wzR+m1T+0OS9dL1NeiBv54Zuo27zA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeekgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinheplhhisgdrmhhknecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E7D083280060; Tue, 18 Feb 2020 04:47:05 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ray.kinsella@intel.com, nhorman@tuxdriver.com, bluca@debian.org, david.marchand@redhat.com, ktraynor@redhat.com Date: Tue, 18 Feb 2020 10:47:04 +0100 Message-ID: <3723540.yKVeVyVuyW@xps> In-Reply-To: <20200218094012.GA875@bricha3-MOBL.ger.corp.intel.com> References: <44659287.fMDQidcC6G@xps> <20200217234402.2235904-1-thomas@monjalon.net> <20200218094012.GA875@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: fix soname for experimental libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/02/2020 10:40, Bruce Richardson: > On Tue, Feb 18, 2020 at 12:44:02AM +0100, Thomas Monjalon wrote: > > Because of an original mistake in ABI numbering, > > and a temporary workaround for ABI 20, > > for experimental libs, numbering would lead to consider > > ABI 20.1 > ABI 21.0 > > > > Before this patch: > > > > DPDK 19.11: ABI version 0.200 and soname 0.20 > > DPDK 20.02: ABI version 0.2001 and soname 0.201 > > Numbers are increasing, that's fine. > > For the next major ABI, back to normal numbering: > > DPDK 20.11: ABI version 0.210 and soname 0.21 > > Numbers are decreasing! > > > > After this patch: > > > > DPDK 19.11: ABI version 0.200 and soname 0.20 > > DPDK 20.02: ABI version 0.201 and soname 0.20 > > DPDK 20.11: ABI version 0.210 and soname 0.21 > > > > Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility") > > > > Signed-off-by: Thomas Monjalon > > --- > > config/meson.build | 8 ++++---- > > mk/rte.lib.mk | 4 ++-- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/config/meson.build b/config/meson.build > > index 6c46767e3e..e7cd74e2c2 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -27,12 +27,12 @@ abi_version = run_command(find_program('cat', 'more'), > > # and the filename suffix as 0.majorminor versions, > > # e.g. v20.1 => librte_stable.so.20.1, librte_experimental.so.0.201 > > # sonames => librte_stable.so.20, librte_experimental.so.0.20 > > -# e.g. v20.0.1 => librte_stable.so.20.0.1, librte_experimental.so.0.2001 > > -# sonames => librte_stable.so.20.0, librte_experimental.so.0.200 > > +# e.g. v20.0.1 => librte_stable.so.20.0.1, librte_experimental.so.0.201 > > +# sonames => librte_stable.so.20.0, librte_experimental.so.0.20 > > abi_va = abi_version.split('.') > > stable_so_version = abi_va.length() == 2 ? abi_va[0] : abi_va[0] + '.' + abi_va[1] > > -experimental_abi_version = '0.' + ''.join(abi_va) > > -experimental_so_version = '0.' + ''.join(stable_so_version.split('.')) > > +experimental_abi_version = '0.' + ''.join([abi_va[0], abi_va[2]]) > > +experimental_so_version = '0.' + ''.join([abi_va[0]]) > > > > My concern about this is that it will break, or rather need to be changed > again for the 20.11 release. While I see the numbering as not-ideal in > terms of version numbers, the existing scheme was originally designed to > work with either 3-digit or 2-digit version numbers. It could be improved to work with 2-digit too.