* [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit
@ 2016-06-23 22:44 Thomas Monjalon
2016-06-24 9:30 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-23 22:44 UTC (permalink / raw)
To: dev
It is better to keep the line "Fixes:" longer than 75 characters
than splitting.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
scripts/check-git-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 153f378..4253d14 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -111,7 +111,7 @@ bad=$(echo "$headlines" | awk 'length>60 {print}' | sed 's,^,\t,')
[ -z "$bad" ] || printf "Headline too long:\n$bad\n"
# check body lines length (75 max)
-bad=$(echo "$bodylines" | awk 'length>75 {print}' | sed 's,^,\t,')
+bad=$(echo "$bodylines" | grep -v '^Fixes:' | awk 'length>75 {print}' | sed 's,^,\t,')
[ -z "$bad" ] || printf "Line too long:\n$bad\n"
# check tags spelling
--
2.7.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit
2016-06-23 22:44 [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit Thomas Monjalon
@ 2016-06-24 9:30 ` Bruce Richardson
2016-06-25 13:59 ` Wiles, Keith
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2016-06-24 9:30 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:
> It is better to keep the line "Fixes:" longer than 75 characters
> than splitting.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Definite +1
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit
2016-06-24 9:30 ` Bruce Richardson
@ 2016-06-25 13:59 ` Wiles, Keith
2016-06-27 14:54 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Wiles, Keith @ 2016-06-25 13:59 UTC (permalink / raw)
To: Richardson, Bruce, Thomas Monjalon; +Cc: dev
On 6/24/16, 4:30 AM, "dev on behalf of Bruce Richardson" <dev-bounces@dpdk.org on behalf of bruce.richardson@intel.com> wrote:
>On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:
>> It is better to keep the line "Fixes:" longer than 75 characters
>> than splitting.
>>
>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
>Definite +1
Yes, +2 for me.
>
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit
2016-06-25 13:59 ` Wiles, Keith
@ 2016-06-27 14:54 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-27 14:54 UTC (permalink / raw)
To: Wiles, Keith; +Cc: Richardson, Bruce, dev
2016-06-25 13:59, Wiles, Keith:
> On 6/24/16, 4:30 AM, "dev on behalf of Bruce Richardson" <dev-bounces@dpdk.org on behalf of bruce.richardson@intel.com> wrote:
>
> >On Fri, Jun 24, 2016 at 12:44:18AM +0200, Thomas Monjalon wrote:
> >> It is better to keep the line "Fixes:" longer than 75 characters
> >> than splitting.
> >>
> >> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> >Definite +1
>
> Yes, +2 for me.
Applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-27 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-23 22:44 [dpdk-dev] [PATCH] scripts: relax line length check for fixed commit Thomas Monjalon
2016-06-24 9:30 ` Bruce Richardson
2016-06-25 13:59 ` Wiles, Keith
2016-06-27 14:54 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).