From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 310831075
 for <dev@dpdk.org>; Thu, 16 Mar 2017 18:35:17 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id n11so118015506wma.1
 for <dev@dpdk.org>; Thu, 16 Mar 2017 10:35:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Ju6E5VIgqQhDv5iNcH7zySo2nb6HzSw0n8qcISzt11s=;
 b=fDDErO133MkBacCvR0do1sLfv9m2VtR3LdWudbNzGTdemJSilhOzWsSS7rx6fs5OlB
 tgIXkBWZw118JsViu1JAhwSEfH5rhxgM1Nqg+nVBP6fcTZSSrhvzGQYrePjp/m6/j0ZT
 j6Qray+tmMsbjqhzGpU5J004m574tMJ+5GAwLRM24TXGreSRg/USYnlirhQMCW87L7E4
 UnccEbScxaBQfH23iWGg8HjVixhCVbu0UsJnHNLzqGJXIMpWAAfSBmLRvsmIyaMMtuAN
 rKV5JILEHhe7R+WFYltIPF6+bwK++PZL6iX1Rwo7GRu4Gur4HERN7xQxusGVmbUwuLRS
 DmZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=Ju6E5VIgqQhDv5iNcH7zySo2nb6HzSw0n8qcISzt11s=;
 b=LFJnTjuKc+yH7HPNcNUOSBGV1weqtVPgomRGZG7g/AmTTSQNFshYmID7attpNpkgXW
 TzzfVVG9wxNAtDtwkfwwH7/JT6MlE9nFKjA3Amf6CBnll0zrGmiEtWPT5LUNMvXz9ET2
 IByAKfUR+vNNweoVyG44GGxFjLuVW63vzyK6KK5cFVJ6C1D7BQ4dd0jF2cW1r2iqjiCc
 aMf91CKUnbdjn5EwJ+z1GiupKqPHW7cRHvnCuldkn4XTmBGDzi1qn7fgKidMVOgCvwJw
 zr3LKPMz4GnKlX3tyJRxZqvhd77ykD/nPeoHb8s2jsdOAV4z/c50BLtBgCbuzTpsbVO5
 CS7g==
X-Gm-Message-State: AFeK/H3oOrajKrVGVyUlTaK7iim2jTo2DxDKXjX8hNZAGtLOvvWrL/77iR0+idbd84UbNg0K
X-Received: by 10.28.111.151 with SMTP id c23mr25934756wmi.17.1489685716820;
 Thu, 16 Mar 2017 10:35:16 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id v3sm6997893wrb.39.2017.03.16.10.35.16
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Mar 2017 10:35:16 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
 balasubramanian.manoharan@cavium.com, hemant.agrawal@nxp.com,
 shreyansh.jain@nxp.com
Date: Thu, 16 Mar 2017 18:35:15 +0100
Message-ID: <3726722.PXkB3N0h2d@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
References: <1488589820-206947-1-git-send-email-cristian.dumitrescu@intel.com>
 <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: add hierarchical scheduler API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Mar 2017 17:35:17 -0000

2017-03-04 01:10, Cristian Dumitrescu:
> This patch introduces the generic ethdev API for the traffic manager
> capability, which includes: hierarchical scheduling, traffic shaping,
> congestion management, packet marking.
> 
> Main features:
> - Exposed as ethdev plugin capability (similar to rte_flow approach)
> - Capability query API per port, per hierarchy level and per hierarchy node
> - Scheduling algorithms: Strict Priority (SP), Weighed Fair Queuing (WFQ),
>   Weighted Round Robin (WRR)
> - Traffic shaping: single/dual rate, private (per node) and shared (by multiple
>   nodes) shapers
> - Congestion management for hierarchy leaf nodes: algorithms of tail drop,
>   head drop, WRED; private (per node) and shared (by multiple nodes) WRED
>   contexts
> - Packet marking: IEEE 802.1q (VLAN DEI), IETF RFC 3168 (IPv4/IPv6 ECN for
>   TCP and SCTP), IETF RFC 2597 (IPv4 / IPv6 DSCP)

Please could you split some parts of this API in separate patches?
And it would be nice to add some text in the programmer's guide as part
of the API patches. It will help the review.
It could provide you the opportunity to explain the rationale in the
commit messages of each part and save it in the git history.

Last detail, please Cristian, try to be concise when writing such
explanations ;)

Thanks