* [dpdk-dev] [PATCH] net/qede: fix icc build
@ 2017-11-07 23:38 Ferruh Yigit
2017-11-08 0:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2017-11-07 23:38 UTC (permalink / raw)
To: Rasesh Mody, Harish Patil, Shahed Shaikh; +Cc: dev, Ferruh Yigit, stable
observed icc version "icc (ICC) 18.0.0 20170811"
build error:
.../dpdk/drivers/net/qede/qede_ethdev.c(1475):
error #279: controlling expression is constant
assert(false && "Unable to start periodic timer");
^
Warning disabled in Makefile.
Fixes: 2af14ca79c0a ("net/qede: support 100G")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/qede/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index a166e9fa8..ccbffa45d 100644
--- a/drivers/net/qede/Makefile
+++ b/drivers/net/qede/Makefile
@@ -72,8 +72,9 @@ CFLAGS_BASE_DRIVER += -Wno-sometimes-uninitialized
ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0)
CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion
endif
-else
-CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type
+else #ICC
+CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type
+CFLAGS_qede_ethdev.o += -wd279 #279: controlling expression is constant
endif
#
--
2.13.6
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/qede: fix icc build
2017-11-07 23:38 [dpdk-dev] [PATCH] net/qede: fix icc build Ferruh Yigit
@ 2017-11-08 0:26 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-11-08 0:26 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: stable, Rasesh Mody, Harish Patil, Shahed Shaikh, dev
08/11/2017 00:38, Ferruh Yigit:
> observed icc version "icc (ICC) 18.0.0 20170811"
>
> build error:
> .../dpdk/drivers/net/qede/qede_ethdev.c(1475):
> error #279: controlling expression is constant
> assert(false && "Unable to start periodic timer");
> ^
>
> Warning disabled in Makefile.
>
> Fixes: 2af14ca79c0a ("net/qede: support 100G")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-08 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 23:38 [dpdk-dev] [PATCH] net/qede: fix icc build Ferruh Yigit
2017-11-08 0:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).