From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F99BA00C2; Thu, 23 Apr 2020 12:48:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9245D1D410; Thu, 23 Apr 2020 12:48:54 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0251C1D177 for ; Thu, 23 Apr 2020 12:48:53 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5A5DE5C01BC; Thu, 23 Apr 2020 06:48:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 23 Apr 2020 06:48:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Q8pMvM/5H1kQ8me+xc4EXpQapTP2ETFZ7EKIfpgjSKs=; b=C8KrXs8jOSGC9Unn bLCB+KHAMjrmVL6b6wD4Rtip4Vonkr0CzcABZqYB1AdtNeRDRRxExaVSCMiqwUDp Cjs6H2IHS76c+wlYyuYahh+Df+D7ML5Plk4xDTdgJekllv7YpU31lrLcAx2tBqiD OkEgxsv+6O2esRUqiuXgMfqX8O/PmjL9AfRwTyaTOlQE0IQD1lc7Io+GUuhJc3NX gfBC7O9UVOdjBKE9Av8ob6y8K7sw1U2jxkxkSxyib05XYIIPsXUgVKTfjLdyoQxI vp3Db7CpAWTy0xf9RudETPLcojLM1ffHjzq+/61ytOVw3Wt0H9D9FAul8r858UZu Gu8vtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Q8pMvM/5H1kQ8me+xc4EXpQapTP2ETFZ7EKIfpgjS Ks=; b=FUYqtE1TQWvRiGJGelNOG2zmsHRVvB/bcMUjEPCbo/OrFFEVAjjSvWyk1 avRwtr2iPD4CWDhTQz8bLdFz9L9fTzMOmF7WZ+iL+Byu5y3Ijj8c/9EXYqUoC3pk VNEmxvBmTjzJmim39JcPQnw20IJic+0XmbMDakOSXDMlhDolGJUojvvY0fmhuD99 dtwO1fawfz22SyIbCsFMrLh+4ZxaLbb3yeD4Xq/bMemlElcKpLJnNfikfmLdVOP8 hAFFvHJk4tiUZDQEAurAy7ah11yZ3hjvbCMObZOugi4tu/wAfh3z2KJ7NXYc57ky f3fUO/pMAcLcSbaRBLz0GPP9vgEkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeelgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3DAE4328005E; Thu, 23 Apr 2020 06:48:52 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Ranjit Menon , talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net Date: Thu, 23 Apr 2020 12:48:51 +0200 Message-ID: <3727963.e99z0qppnp@thomas> In-Reply-To: <20200423120643.0173e2d2@Sovereign> References: <20200422072747.15960-1-talshn@mellanox.com> <15414965.hlxOUv9cDv@thomas> <20200423120643.0173e2d2@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/04/2020 11:06, Dmitry Kozlyuk: > On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: > > 23/04/2020 01:51, Ranjit Menon: > > > On 4/22/2020 12:27 AM, talshn@mellanox.com wrote: > > > > From: Tal Shnaiderman > > > > > > > > Move common functions between Unix and Windows to eal_config.c. > > > > > > Like other files in common, we should call this eal_common_config.c > > > > I am not sure about the interest of repeating the directory name > > in the file name in general. > > Do you see a real benefit? > > It allows using VPATH in Makefile. If filenames are identical in different > VPATH directories, make can't pick both. Makefiles are being deprecated, but > they'll be around for some more time. Makefile will be removed in 20.11