From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,
navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com,
Ranjit Menon <ranjit.menon@intel.com>,
ocardona@microsoft.com, khot@microsoft.com,
dmitrym@microsoft.com
Subject: Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows
Date: Wed, 14 Oct 2020 11:01:32 +0200 [thread overview]
Message-ID: <3728316.aShtntb2fh@thomas> (raw)
In-Reply-To: <22b0021f-cf02-1d21-7236-9385e6d5f490@intel.com>
16/09/2020 20:32, Ranjit Menon:
> On 8/25/2020 4:43 AM, Tal Shnaiderman wrote:
> > Set the domain value for rte_pci_addr probing on Windows
> > to the value of the PCI segment returned by SPDRP_BUSNUMBER.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > --- a/drivers/bus/pci/windows/pci.c
> > +++ b/drivers/bus/pci/windows/pci.c
> > @@ -195,8 +195,8 @@ get_device_pci_address(HDEVINFO dev_info,
> > - addr->domain = 0;
> > - addr->bus = bus_num;
> > + addr->domain = bus_num >> 8;
> > + addr->bus = bus_num & 0xff;
> > addr->devid = dev_and_func >> 16;
> > addr->function = dev_and_func & 0xffff;
>
>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
I was waiting for feedback from Microsoft, but never happened, so
Applied, thanks
Microsoft, we need a better support for porting DPDK on Windows.
prev parent reply other threads:[~2020-10-14 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:43 Tal Shnaiderman
2020-09-09 23:21 ` Narcisa Ana Maria Vasile
2020-09-10 7:30 ` Tal Shnaiderman
2020-09-10 17:21 ` Menon, Ranjit
2020-09-13 14:50 ` Tal Shnaiderman
2020-09-10 17:57 ` Dmitry Kozlyuk
2020-09-13 14:54 ` Tal Shnaiderman
2020-09-16 18:32 ` Ranjit Menon
2020-10-14 9:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3728316.aShtntb2fh@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=khot@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).