From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E12B6A0521; Tue, 24 Nov 2020 23:18:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39593C932; Tue, 24 Nov 2020 23:18:41 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id F0FC0C930 for ; Tue, 24 Nov 2020 23:18:39 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5AE655C022D; Tue, 24 Nov 2020 17:18:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 24 Nov 2020 17:18:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= FYf4jhdH6rVhjFDWRSWz7zHoyqkI1kOA7gD9Qy5Befg=; b=udpzP8sFzODt/gci 8BOpj0HDWqT/bT8JoUAt+4BXq0bApdb9T2WARauMHLerMgK73iNX5be8mJSd8nbR F270EFJ+ecmlwV9FbUZ8KLMl8Pj2SBJIzcwK08T1V2vEOTDrAebWw6ZxmDzCWbAI IN+BoZhAFGR/MAyN1AnUXvTsmom5Osc8o70ZS82CKANcG6a9QYdW9o0LW9cR1xCc 9+d4z1gebXVqKHhC9B+/a9eSd8cD+4OPI/JWCnPS+unhukr6HVHPJWcHy6cS4XZD bJXabGCY+qk5GCZ+6a9mmELQj156TSI8VrM57y/QWMXwjPnYVEyJKQUoPxRkMqF5 SUDkDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FYf4jhdH6rVhjFDWRSWz7zHoyqkI1kOA7gD9Qy5Be fg=; b=LdgCu+163s7+GVq9tjGevOpe4DP8zU2cdxLlCxcf7wYoykWQswCKplwTX xGhhfS8F0UJoQp4aoxwZwBJlgEQrjs2R1Dy+YHKwReRvxMgz1oonV58pGqF5aAK3 Ev6PU55AdU5AipXaoWG9Y5qrptLUxslGsglUzbg++9jPmci+QJ75kusr3JwPVNmt 3MgiV7SOgDMbcfzlkyqP+cAlsSL9wB4eSXlrW4Qv7ubHWpbsukKBhwLpEI6Ni31W B/Wpa7n3U4Gdp/JlBTDyFTY+7MnabLdOQvEjnPAenvBu+T0xwFMpeY/jV4QnNKyK uiXjLQ6XyJ9v3FgXxlf9s8aIioqsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegkedgudeiudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DECBB3064AB0; Tue, 24 Nov 2020 17:18:36 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: "dev@dpdk.org" , Raslan Darawsheh , Slava Ovsiienko , Shahaf Shuler , Michael Baum , Matan Azrad , asafp@nvidia.com Date: Tue, 24 Nov 2020 23:18:35 +0100 Message-ID: <3728853.Nl63JOqJJY@thomas> In-Reply-To: References: <20201124081013.1912-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix DevX resources memory management. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Invalid memory release order of DevX resources caused PMD crash. > > > > 1. SQ and CQ memory must be unregistered with DevX before it is freed. > > 2. SQ objects reference to a CQ ones. Hence, SQ should be destroyed in > > advance of CQ it references to. > > > > Fixes: 6deb19e1b2d2 ("net/mlx5: separate Rx queue object creations") > > Fixes: 88f2e3f18cc7 ("net/mlx5: rearrange SQ and CQ creation in DevX > > module") > > > > Signed-off-by: Gregory Etelson > > Acked-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad Applied, thanks