From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Pankaj Gupta <pagupta@vmware.com>, jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org Subject: Re: [PATCH v4 5/8] net/vmxnet3: version 6 Date: Thu, 12 May 2022 13:57:41 +0300 Message-ID: <372e46ce-5cde-ba0e-835b-cec7d2557b3e@oktetlabs.ru> (raw) In-Reply-To: <20220505220019.31166-6-pagupta@vmware.com> On 5/6/22 01:00, Pankaj Gupta wrote: > vmxnet3 version 6 supports some new features, including but > not limited to: > - Increased max MTU up to 9190 > - Increased max number of queues, both for Rx and Tx > - Removes power-of-two limitations > - Extended interrupt structures, required implementation for > additional number of queues > > Tested, using testpmd, for different hardware version on > ESXi 7.0 Update 2. > > Signed-off-by: Pankaj Gupta <pagupta@vmware.com> > Reviewed-by: Jochen Behrens <jbehrens@vmware.com> [snip] > @@ -1377,9 +1428,30 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > { > struct vmxnet3_hw *hw = dev->data->dev_private; > + int queues = 0; > + > + if (VMXNET3_VERSION_GE_6(hw)) { > + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, > + VMXNET3_CMD_GET_MAX_QUEUES_CONF); > + queues = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD); > + > + if (queues > 0) { > +#ifndef MIN > +#define MIN(x, y) (((x) < (y)) ? (x) : (y)) > +#endif checkpatches.sh produces a warning here. Can we use RTE_MIN() instead below? > + dev_info->max_rx_queues = > + MIN(VMXNET3_EXT_MAX_RX_QUEUES, ((queues >> 8) & 0xff)); > + dev_info->max_tx_queues = > + MIN(VMXNET3_EXT_MAX_TX_QUEUES, (queues & 0xff)); > + } else { > + dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES; > + dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES; > + } > + } else { > + dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES; > + dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES; > + } > > - dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES; > - dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES; > dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM; > dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */ > dev_info->min_mtu = VMXNET3_MIN_MTU; [snip]
next prev parent reply other threads:[~2022-05-12 10:57 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 22:00 [PATCH v4 0/8] vmxnet3 version V5 and V6 Pankaj Gupta 2022-05-05 22:00 ` [PATCH v4 1/8] net/vmxnet3: add V5 support Pankaj Gupta 2022-05-05 22:00 ` [PATCH v4 2/8] net/vmxnet3: implement reta query and reta update Pankaj Gupta 2022-05-12 10:58 ` Andrew Rybchenko 2022-05-05 22:00 ` [PATCH v4 3/8] net/vmxnet3: add Rx queue usage count utility Pankaj Gupta 2022-05-12 10:59 ` Andrew Rybchenko 2022-05-05 22:00 ` [PATCH v4 4/8] net/vmxnet3: report HW version on FW version get Pankaj Gupta 2022-05-05 22:00 ` [PATCH v4 5/8] net/vmxnet3: version 6 Pankaj Gupta 2022-05-12 10:57 ` Andrew Rybchenko [this message] 2022-05-05 22:00 ` [PATCH v4 6/8] net/vmxnet3: advertise RETA size in device info Pankaj Gupta 2022-05-05 22:00 ` [PATCH v4 7/8] net/vmxnet3: set packet type for fragmented packet Pankaj Gupta 2022-05-05 22:00 ` [PATCH v4 8/8] Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Pankaj Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=372e46ce-5cde-ba0e-835b-cec7d2557b3e@oktetlabs.ru \ --to=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=jbehrens@vmware.com \ --cc=pagupta@vmware.com \ --cc=yongwang@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git