From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AD1B92952 for ; Thu, 11 May 2017 19:18:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 448BB207E6; Thu, 11 May 2017 13:18:09 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 11 May 2017 13:18:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=tCTpYzROeOhLfVo CRRo9UbdpvrXHaRyraVKvz5BWt4A=; b=jucY3MiO3na+z4QC+Pt7+O3TCGAKUw0 SHNWyxS0m5rG0gQjR9c42CqkdokCyVkMxdB1lwaYllC6jPHljbtXq+jm/i+iR8Lb s0UbzR8cn2HYF2ugGhQpeGIMRd29GWq/dGuees5SvU1XdXrr71bqfW7+pvrb//q7 MPKmyo+F8B2g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=tCTpYzROeOhLfVoCRRo9UbdpvrXHaRyraVKvz5BWt4A=; b=WcwkpDz9 IcCqLH6ufkj2Ja7M8C7dWczvrf2lXjiLVKI1uce/liwJUvYXUHNxna01tzrDlBa9 Oh9MvwlNIT8uv9pBb50ZiEuCc/HvDpIsoimqWlUJ1sLOZYQs34SIbqk8pucN5pS9 U6zJ4Lzztem88+V9xFJcmon+Bze1Yi5gmkbV+i2sl3lAZoQpPQlZFnHohcHd3GOM wxo45tzLqfsHY3SOMq5TM2siMU2FzlVZS2+LE3CRCPs6j0V+V9U8h1U4GvDC+o7E nOc1lex5W46RLMflLa1Hitq6ca4Cn253/pVZDQMhXMl5/cLdluLrmbaKqIgiYANx Ft1T9zhIPRlryA== X-ME-Sender: X-Sasl-enc: CL2JO17FuM8oeTLTfFyLb2WQBCQQYFphIqdsYRE6DRjT 1494523088 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E45607E98A; Thu, 11 May 2017 13:18:08 -0400 (EDT) From: Thomas Monjalon To: "Mcnamara, John" Cc: dev@dpdk.org Date: Thu, 11 May 2017 19:18:07 +0200 Message-ID: <3737023.yBcUv04Hz8@xps> In-Reply-To: References: <1494511780-5732-1-git-send-email-john.mcnamara@intel.com> <6951954.sJVyEfo4GT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] doc: change doc line length limit in contributors guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 17:18:11 -0000 11/05/2017 18:11, Mcnamara, John: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > ... > > > -* The recommended style for the DPDK documentation is to put sentences > > on separate lines. > > > - This allows for easier reviewing of patches. > > > - Multiple sentences which are not separated by a blank line are joined > > automatically into paragraphs, for example:: > > > +* Lines in sentences should be less than 80 characters and wrapped at > > > + words. Multiple sentences which are not separated by a blank line > > > +are joined > > > + automatically into paragraphs. > > > > Why not keep the recommendation of separating sentences? > > This isn't a recommendation. It is just pointing out that lines and sentences > are joined into paragraphs. Maybe that is obvious and doesn't need to be > stated. I'm talking about "The recommended style for the DPDK documentation is to put sentences on separate lines." I like this recommendation. > > > + testpmd -l 2-3 -n 4 \ > > > + --vdev=virtio_user0,path=/dev/vhost- > > net,queues=2,queue_size=1024 \ > > > + -- -i --txqflags=0x0 --disable-hw-vlan --enable-lro \ > > > + --enable-rx-cksum --txq=2 --rxq=2 --rxd=1024 --txd=1024 > > > > Garbage? > > I hope not. I took it from one of the examples in the docs to demonstrate > how a long command could be wrapped and still be functional. Should I > clarify that more, or remove it? Ah sorry, misreading the patch.