From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6565EA034E; Wed, 9 Feb 2022 19:51:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D07041101; Wed, 9 Feb 2022 19:51:20 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 9692F40140 for ; Wed, 9 Feb 2022 19:51:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0EE915C00B9; Wed, 9 Feb 2022 13:51:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 Feb 2022 13:51:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=EdFA31I9SdhNmn Eov0oAT61c0q1rCkkjexfGyZxIhAA=; b=fQBk5J9UXWh0raYXf9QY0BU8IGHOPk cWlRltddgP6EMEiXcxkJkV5Fg1li8ESYKZXPCZLkbhmS4Jckbf5YJUw+ETstCxEA OqzLjaAccJen4rmhA7Eu6ULq21BLwkOWjRA/Ha6PkZUeexKTJAXifjQGy690i2TM oHDcuoVi4tM6pk0nrgO+WlDmYpr4zbPAmFImZFiJ7pBCZkloWcNzJ0iB9x05VhPT GRU6ZX/pdiqvSrh527hh0FKNo0Da8h+B5rdtnMDlsIi7aUZLoQb/p9wwpfdzSgnb wQnorZuWCXLV6mxpRt4fs7BkfLykz13XV43u7MXi5lNPrKmXdcX8c8Lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EdFA31I9SdhNmnEov0oAT61c0q1rCkkjexfGyZxIh AA=; b=MgKVo621GU2DTB3H16kdoFM+lX9T6B8dn2hK/5gz1IRHM7yFmKDVIV9HU SqYJ1Y7IA/hS+fV6/ORXTSgLWP8mBe/rFUWORlGKXImIAIMmf6OlOl173yScFUs5 c9vlr1hGLHXbx+hjpRX/1sKP6wmioe0oSTlhH6tYijeTyQFEKuYTB0duadj782eW UzBPyJ4xBQNlK+z3/NrQcvi/5KkoDpb2qR0a7/uph1lvaD4qQ2orXIyzqerIaIuQ NFcAswZVKVDl7jtZIZT6dadZPYVHhZumGu2WHk9QKDlLMb+2VSwUeorXVGSQIbGa 7rxGoTifeiTkFtWmZdyaT5aEPFYkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Feb 2022 13:51:17 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger , david.marchand@redhat.com Subject: Re: [PATCH] eal: remove unnecessary argv[0] handling Date: Wed, 09 Feb 2022 19:51:15 +0100 Message-ID: <37375521.10thIPus4b@thomas> In-Reply-To: <20220209074519.6b3f3f5e@hermes.local> References: <20220202194738.404876-1-stephen@networkplumber.org> <2032198.bB369e8A3T@thomas> <20220209074519.6b3f3f5e@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/02/2022 16:45, Stephen Hemminger: > On Wed, 09 Feb 2022 15:58:26 +0100 > Thomas Monjalon wrote: > > > 02/02/2022 20:47, Stephen Hemminger: > > > The rte_eal_init function looks at argv[0] to determine > > > the program name to pass to the log init function. > > > This is both unnecessary and in a corner case a problem. > > > > > > Parsing argv[0] is unnecessary because the function openlog() > > > already determines the log identifier from program name if > > > NULL is passed, see openlog man page: > > > The string pointed to by ident is prepended to every message, and is > > > typically set to the program name. If ident is NULL, the program name > > > is used. (POSIX.1-2008 does not specify the behavior when ident is > > > NULL.) > > > > What about POSIX warning? > > Did you test it? Which libc? What about musl? > > Source for musl shows that openlog accepts NULL as ident. > It then generates log messages with ident in the message. In this case, it will be empty string. It seems this solution does not work with musl.