From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
Elad Nachman <eladv6@gmail.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, stable@dpdk.org, Igor Ryzhov <iryzhov@nfware.com>,
Eric Christian <erclists@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Sahithi Singam <sahithi.singam@oracle.com>
Subject: Re: [PATCH v2] kni: restrict bifurcated device support
Date: Wed, 24 Nov 2021 14:51:57 +0100 [thread overview]
Message-ID: <3741185.2VLPbhnIhI@thomas> (raw)
In-Reply-To: <20211123164618.3585878-1-ferruh.yigit@intel.com>
23/11/2021 17:46, Ferruh Yigit:
> To enable bifurcated device support, rtnl_lock is released before calling
> userspace callbacks and asynchronous requests are enabled.
>
> But these changes caused more issues, like bug #809, #816. To reduce the
> scope of the problems, the bifurcated device support related changes are
> only enabled when it is requested explicitly with new 'enable_bifurcated'
> module parameter.
> And bifurcated device support is disabled by default.
>
> So the bifurcated device related problems are isolated and they can be
> fixed without impacting all use cases.
>
> Bugzilla ID: 816
> Fixes: 631217c76135 ("kni: fix kernel deadlock with bifurcated device")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Igor Ryzhov <iryzhov@nfware.com>
This approach looks pragmatic.
BTW, I'm not sure there is a strong need for KNI with bifurcated device.
Applied, thanks.
prev parent reply other threads:[~2021-11-24 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 23:58 [dpdk-dev] [PATCH] " Ferruh Yigit
2021-10-09 2:03 ` Stephen Hemminger
2021-11-23 9:54 ` Ferruh Yigit
2021-11-23 16:22 ` Stephen Hemminger
2021-11-23 16:51 ` Ferruh Yigit
2021-11-23 19:10 ` Stephen Hemminger
2021-11-17 16:42 ` Igor Ryzhov
2021-11-23 16:46 ` [PATCH v2] " Ferruh Yigit
2021-11-24 13:51 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3741185.2VLPbhnIhI@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eladv6@gmail.com \
--cc=erclists@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
--cc=sahithi.singam@oracle.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).