DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>, Akhil Goyal <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXT] [PATCH] net: fix build with -Wpedantic
Date: Thu, 29 Sep 2022 09:09:59 +0200	[thread overview]
Message-ID: <3741631.FjKLVJYuhi@thomas> (raw)
In-Reply-To: <CO6PR18MB4484E1DC5F0021D3D2067125D8579@CO6PR18MB4484.namprd18.prod.outlook.com>

29/09/2022 09:01, Akhil Goyal:
> > Adds the __extension__ attribute to resolve the following warning
> > with gcc 4.8.5 on CentOS 7:
> > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> >   a GCC extension [-Werror=pedantic]
> > 
> > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > Cc: gakhil@marvell.com
> > 
> > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > ---
> > --- a/lib/net/rte_macsec.h
> > +++ b/lib/net/rte_macsec.h
> > @@ -28,6 +28,7 @@ extern "C" {
> >  /**
> >   * MACsec Header (SecTAG)
> >   */
> > +__extension__
> 
> RTE_STD_C11 ??

We use RTE_STD_C11 only for anonymous struct and union.
I don't know why we don't use it for bitfield in struct.
It seems to be part of C11 standard, right?

In doubt, I would continue with __extension__
and we can replace all similar occurences in a separate patch,
if confirmed it is well defined in C11.



      parent reply	other threads:[~2022-09-29  7:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  6:50 Ali Alnubani
2022-09-29  7:01 ` [EXT] " Akhil Goyal
2022-09-29  7:07   ` Ali Alnubani
2022-09-29  7:09     ` Akhil Goyal
2022-09-29  7:20       ` Thomas Monjalon
2022-09-29  7:09   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3741631.FjKLVJYuhi@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).