From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D29DA04B6; Mon, 12 Oct 2020 19:19:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E2C031D956; Mon, 12 Oct 2020 19:19:30 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id A88DF1D955 for ; Mon, 12 Oct 2020 19:19:29 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 400D3580119; Mon, 12 Oct 2020 13:19:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 12 Oct 2020 13:19:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= wd2yVyCkpWdwmWdC9Orl1yRIJfDCOrpBxlGDLAzVYoY=; b=jAXpVVcWvcaQXjXR rCOnZqvradxrwmXQwLnAIHEZFkJpfYMrZoMP3ZRBktCMUXTrrqnn+h3PWkgmuG6D zvdE/LiM1iDzET/YvCFV5mLCFSRpp0gncran9lp7vZLBoAvFvoEulmzFmm9uAjJI J8ANlbvZqDquoocSWLByXlGL6wve8WZkjqsdozeId+uSFHTVGO8mJ/piTk0Ayiyx ySSIR5tkaih+Swji9xaYjF73Y/BxsDIj8UqljAA+jtgllp631KycGwKKhlFY4egp DhXpiA8iCNVfN/pz/8U1QKkUMwsiOzlA0zLDGyTjDQpwPOBKaxHCOm/wKpD9WHqE dxinhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wd2yVyCkpWdwmWdC9Orl1yRIJfDCOrpBxlGDLAzVY oY=; b=JqJZgNpvOymMKnZcG3Q/JlPtOfchQR94ourB9O7BOgaapB43TzzJjUQMJ YkZLhKkcBTaxqV1vay4ODbibhsN1XXmsdsutoggbjYGC0uK0VUpZhjzlXdxqs5oC aOaJ2X7p3crTVpYvOloce+4c+ZUB9dNYZP9VJIZHFnZ6gHMPA0jLzcDGJfJuLOWT r/Ei+RFz4feC4U75EfY/o0qo/X8ahtiRi4TBm7eBDUJC7Nf9AeMKTv8ruAXCvs74 QTlxn/qaTk6cqKTRuERun1OXWVwsWTUPBJWFxcGczSgCOtMQpORAEF7sg88aXJ7B GHb5AUzRGL5wFHbQXl36fWM2mXLvw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheejgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 44DA63064610; Mon, 12 Oct 2020 13:19:25 -0400 (EDT) From: Thomas Monjalon To: Guy Kaneti Cc: "orika@mellanox.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "bruce.richardson@intel.com" , "anatoly.burakov@intel.com" , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "dev@dpdk.org" , Smadar Fuks , Dovrat Zifroni , Liron Himi Date: Mon, 12 Oct 2020 19:19:24 +0200 Message-ID: <3745399.tuykCG01fC@thomas> In-Reply-To: References: <20200901122436.17748-1-guyk@marvell.com> <1991897.isW8xzi4lb@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/10/2020 19:13, Guy Kaneti: > From: Thomas Monjalon > > 12/10/2020 19:06, Guy Kaneti: > > > From: Thomas Monjalon > > > > 12/10/2020 13:31, guyk@marvell.com: > > > > > --- a/meson_options.txt > > > > > +++ b/meson_options.txt > > > > > +option('ree_compiler_sdk', type: 'string', value: '', > > > > > + description: 'path to REE compiler SDK optional library for regex > > > > device') > > > > > > > > Is this SDK specific to Marvell or octeontx2? > > > > If yes, it should appear here. > > > > > > Yes, it is specific to Marvell. > > > > > > > > > > > Why this SDK requires setting the path manually? > > > > Well designed libs should use pkg-config. > > > > You didn't reply this question. > > Really I would prefer avoiding this ugly meson option. > > Please rework the REE SDK to use pkg-config. > > > It is required to be set manually mainly when cross compiling > The target library will not be part of the host system. It does not make sense. The cross-compiled lib is compiled on the host and pkg-config works also for cross-compiling. How do you think other libraries are linked? I don't see why REE should be an exception. It's the same issue with another Marvell SDK: lib_musdk_dir. The other exceptions (which should be removed) are armv8_crypto_dir and flexran_sdk.