From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2AF1A0C47; Thu, 7 Oct 2021 16:11:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EACB411EE; Thu, 7 Oct 2021 16:11:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 985D4411EC for ; Thu, 7 Oct 2021 16:11:40 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 479415C00B6; Thu, 7 Oct 2021 10:11:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 07 Oct 2021 10:11:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= c0lzbTAQs7/M7P8lJJ9jg4qrHwpqNWDFepFFLy9Uo9A=; b=Gm6iU492yAXDeE+b OLPSQQcKPFft1BqGkyM2CBl5uICvHWxdHBQX6x1cBUROFhkZXAU0vFjfzvP7YBOr cVnA5Ampbqo9H0ekxCmPbKan976YT6f1ySiHOeBvjDEDmnf4FnYqic1+LsxQ5BPS 1tM0fD2V38lxARlUSjF4avP+nBthekJ21zFv+khm5RLfLzc07wK70tOTMQgopuQ8 NgYuSswgZS08JDd3YNAWGma4xij1Y00WHYlyhcQbwjA4/4ztsCSPi/+afSj/3nDH il4SPVgvqAMax0bzw22eqmVL6Ckf1kL677i7g8DPXBPJNo7d/Ss0KLAc9u1jmaql E1Z+7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=c0lzbTAQs7/M7P8lJJ9jg4qrHwpqNWDFepFFLy9Uo 9A=; b=YCMyym5CcvKuR437g5Ht5YSJj4l3TXGMmFvfFKs7HN4gRlGKgMKE4EDUL N8cWahXqSif4w5QEAbYbS5N7RvlsBeBn7cHrFcjAMp8Vmsos5CzsEZI9Qhg6PFWp 4Jl6KN8B+iRCYgHO7m4HLdZDxdxIiptquFKDjaxDdOJgQbFKGBHJwLHpObf9LWbi 0R3RfeYyvgiewOJA3wHSVrJ58FD9ZfETEZHvvM5cV+dleZMVUIZZE1n8YGVzK4gF 3ZyFQ08n/VM8OiiH2Xhifeq6nLm4KHPKe6G2k9R4Ob5Q3KMm8sz9H33GH3tB8SDT 5Q3VPp+MuaKWDjhz9NkChscp0E+vA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelkedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdekteeviefhgeeftdefjeeukeekkeeuvefgjeeuvdeivddvveeu gfetvedtfeevnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Oct 2021 10:11:38 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Ferruh Yigit Cc: dev@dpdk.org, Ori Kam , Cristian Dumitrescu , david.marchand@redhat.com, aconole@redhat.com Date: Thu, 07 Oct 2021 16:11:35 +0200 Message-ID: <3749057.Eksa6WUJdZ@thomas> In-Reply-To: <20211007132700.452945-1-thomas@monjalon.net> References: <20210915210444.3126008-1-thomas@monjalon.net> <20211007132700.452945-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/10/2021 15:26, Thomas Monjalon: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. >=20 > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. >=20 > The API of rte_mtr and rte_tm is using enums for 64-bit variables. > As they are enums, RTE_BIT32 is used. > The corresponding struct members should be converted to 32-bit. According to this report: http://mails.dpdk.org/archives/test-report/2021-October/224792.html Ubuntu 18.04 does not accept this change: rte_tm.h:181:2: error: enumerator value for =E2=80=98RTE_TM_UPDATE_NODE_ADD= _DELETE=E2=80=99 is not an integer constant RTE_TM_UPDATE_NODE_ADD_DELETE =3D RTE_BIT32(2), Anybody understands why?