From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson
Date: Tue, 14 Apr 2020 06:48:16 +0000 [thread overview]
Message-ID: <374c25e10cda4e5399cb53f3a30478b2@pantheon.tech> (raw)
In-Reply-To: <20200410094624.GB625@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
-----Original Message-----
From: Bruce Richardson <bruce.richardson@intel.com>
Sent: Friday, April 10, 2020 11:46 AM
To: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: dev@dpdk.org
Subject: Re: [PATCH] build: add arm 32bit cross compilation to Meson
On Thu, Apr 09, 2020 at 04:14:48PM +0200, Juraj Linkeš wrote:
> * Add arm-linux-gnueabihf cross-file
> * Add generic and default arm 32 bit flags to arm meson.build
> * Add support for disabling drivers using flags defined in Meson
> * Change checks from dpdk_conf.has() to dpdk.conf.get()
> * When processing which drivers to build, check whether the
> appropriate RTE flag isn't set to false
>
This is probably best done as separate patches that can be reviewed separately. While the first two seem straight-forward, the last item seems strange and should be reviewed separately. Why do you want flags defined in meson to enable/disable drivers? It's taking a big step back towards having a statically defined configuration, which is something we really want to get away from.
/Bruce
I will split the patch.
I don't have any particular reason to do it this way. What should I do? Add conditions that check for arm32 build to each of these drivers?
Thanks,
Juraj
next prev parent reply other threads:[~2020-04-14 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 14:14 Juraj Linkeš
2020-04-10 9:46 ` Bruce Richardson
2020-04-14 6:48 ` Juraj Linkeš [this message]
2020-04-13 6:23 ` Ruifeng Wang
2020-04-14 7:05 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=374c25e10cda4e5399cb53f3a30478b2@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).