From: Thomas Monjalon <thomas@monjalon.net>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Mattias Rönnblom" <hofors@lysator.liu.se>,
"Ruifeng Wang" <Ruifeng.Wang@arm.com>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [PATCH] eal: add notes to SMP memory barrier APIs
Date: Sun, 25 Jun 2023 17:40:56 +0200 [thread overview]
Message-ID: <37506315.XM6RcZxFsP@thomas> (raw)
In-Reply-To: <AS8PR08MB7080E37F91E68A7A358D12C29E21A@AS8PR08MB7080.eurprd08.prod.outlook.com>
25/06/2023 10:45, Ruifeng Wang:
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias R�nnblom wrote:
> > > On 2023-06-21 08:44, Ruifeng Wang wrote:
> > > >+ * This function is deprecated. It adds complexity to the memory
> > > >+ model
> > > >+ * used by this project. C11 memory model should always be used.
> > > >+ * rte_atomic_thread_fence() should be used instead.
> > >
> > > It's somewhat confusing to learn I should use the C11 memory model,
> > > and then in the next sentence that I should call a function which is
> > > not in C11.
> >
> > i wonder if we can just do without the comments until we begin to adopt changes for 23.11
> > release because the guidance will be short lived.
> >
> > in 23.07 we want to say that only gcc builtins that align with the standard C++ memory
> > model should be used.
> >
> > in 23.11 we want to say that only standard C11 atomics should be used.
>
> Good point. The memory order parameter will change in 23.11.
>
> >
> > my suggestion i guess is just adapt the patch to be appropriate for
> > 23.11 and only merge it after 23.07 release? might be easier to manage.
>
> Agree to only merge it after 23.07.
> I will update the comment for standard C11 atomics.
I would prefer having each step documented
so it will be clearer what is new in 23.11.
next prev parent reply other threads:[~2023-06-25 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 6:44 Ruifeng Wang
2023-06-21 7:29 ` Thomas Monjalon
2023-06-25 7:55 ` Ruifeng Wang
2023-06-22 18:19 ` Mattias Rönnblom
2023-06-23 21:51 ` Tyler Retzlaff
2023-06-25 8:45 ` Ruifeng Wang
2023-06-25 15:40 ` Thomas Monjalon [this message]
2023-06-25 8:17 ` Ruifeng Wang
2023-06-29 19:28 ` Mattias Rönnblom
2023-07-03 6:12 ` Ruifeng Wang
2023-06-26 7:12 ` [PATCH v2] " Ruifeng Wang
2023-06-29 19:43 ` Mattias Rönnblom
2023-07-03 7:02 ` Ruifeng Wang
2023-07-04 12:08 ` Mattias Rönnblom
2023-07-03 9:56 ` [PATCH v3] " Ruifeng Wang
2023-07-28 9:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37506315.XM6RcZxFsP@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=nd@arm.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).