From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C20142D4B; Sun, 25 Jun 2023 17:41:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B571240ED8; Sun, 25 Jun 2023 17:41:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 559BA40A7F for ; Sun, 25 Jun 2023 17:41:00 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8BF335C0038; Sun, 25 Jun 2023 11:40:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 25 Jun 2023 11:40:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687707659; x=1687794059; bh=D9VFCrMa7P/AN/vU6N790uSKnC+g1fcl0qn TGalZUEI=; b=ZoIuENMQ0XjtBagLNjPeeVbe2lUpCf+mMH2SKkLvrz6EqCo7bt2 cuALTk+DPJmStv01MMRdRxZAi93vUx6G3W3WxWyNXV3utXQtnUSWOW+kHaoeO1gx xFEqjuLAO5yUsLil0dEy3rtjD2a0oKdGBi8y5xgzKR5kxpfoDpqpelGycuGwE1Ut SCxwd/L3tx6G96rB9HK8wBhLmKwvzym49PXKfCE9e49w0MVlDVuF7cPaeHTCUPDj oaidFu2VLmX5UkBjT9G07cmmyDe6M2Oh5K5P8dT2CKH+/gf4hG3qskOJX48uNMiQ QaPQ0bVODrz3IkmhSjPypaGpHguz6mYiA3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687707659; x=1687794059; bh=D9VFCrMa7P/AN/vU6N790uSKnC+g1fcl0qn TGalZUEI=; b=Lm+qzIYboE5bjbZW2dXzYzCBjqaoewnEy079w8/oJemGKD9uNpk LJkRNaDz6n1DuYr1PtvPjJkoyY6bV7XI3yOL3WiWQDmmHo+W2ptPN4cT7Y+snOgw a4ZSt1oVivHQzZQ0EPGun8hv031mU2BJ2wbYgLYX/EK81+lBtyD4lE9x/AfGuAb9 repFuOaJRzceja/lgEEOiJfNx0ztoBsE1NKEKkIU3zRsrdYFjxZajJOSKOQnX3lu iA+Y7N6fGdq5bRagCSfOfSgxn1oy+Ns9WBVCsgBs0UQwBjDlnhddd/g9KncbSvF3 1Ik8YOH4z5JTM6EoE1miIlcCC0pVxvIJjzQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehtddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 25 Jun 2023 11:40:57 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Ruifeng Wang Cc: "david.marchand@redhat.com" , "dev@dpdk.org" , "konstantin.v.ananyev@yandex.ru" , Honnappa Nagarahalli , nd Subject: Re: [PATCH] eal: add notes to SMP memory barrier APIs Date: Sun, 25 Jun 2023 17:40:56 +0200 Message-ID: <37506315.XM6RcZxFsP@thomas> In-Reply-To: References: <20230621064420.163931-1-ruifeng.wang@arm.com> <20230623215118.GC14396@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/06/2023 10:45, Ruifeng Wang: > From: Tyler Retzlaff > > On Thu, Jun 22, 2023 at 08:19:30PM +0200, Mattias R=EF=BF=BDnnblom wrot= e: > > > On 2023-06-21 08:44, Ruifeng Wang wrote: > > > >+ * This function is deprecated. It adds complexity to the memory > > > >+ model > > > >+ * used by this project. C11 memory model should always be used. > > > >+ * rte_atomic_thread_fence() should be used instead. > > > > > > It's somewhat confusing to learn I should use the C11 memory model, > > > and then in the next sentence that I should call a function which is > > > not in C11. > >=20 > > i wonder if we can just do without the comments until we begin to adopt= changes for 23.11 > > release because the guidance will be short lived. > >=20 > > in 23.07 we want to say that only gcc builtins that align with the stan= dard C++ memory > > model should be used. > >=20 > > in 23.11 we want to say that only standard C11 atomics should be used. >=20 > Good point. The memory order parameter will change in 23.11. >=20 > >=20 > > my suggestion i guess is just adapt the patch to be appropriate for > > 23.11 and only merge it after 23.07 release? might be easier to manage. >=20 > Agree to only merge it after 23.07.=20 > I will update the comment for standard C11 atomics. I would prefer having each step documented so it will be clearer what is new in 23.11.