From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D76265905; Mon, 1 May 2017 18:01:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7009720950; Mon, 1 May 2017 12:01:32 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 01 May 2017 12:01:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ShnmNErjYNx6evZ 4eoGX6MHxnOhh/wOnUB/FWO0WV0Q=; b=nZQgzyYaakpGuA/+wttmoFWRg46nZS9 rasEmgDQjqCbfnEgI3ajDgUQcirQiqQvB2eq12APVxrlQP1cLO+VCfeA/Dqddn6x aLjAuryguMqW64fKBIQzc6XpIu/23JD6H/ZMrhW37b87sl07YjFQb33MxG+jw4Mb C38FWCxa+iK8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ShnmNErjYNx6evZ4eoGX6MHxnOhh/wOnUB/FWO0WV0Q=; b=GIt4WoCK +XpNlbW4fvOGkUyhnE3FjV64CbPYud8qNAdAGV3M+38DA7KkfwScmVXKndMpDR5G TpsM9hf2EklHmm5x7XKMYY2N58lZTUfpTTjpafUZlzvpme5ua/sx7eXGmlSXjVEw ODhy9wNE3HNrsed+aU6WPKT5bQ0KOC60JteVZW127bYhv2CUYryw4f6qvWkA2aHt 34L27npZ3pYGJ9oR5eQxthCP9npLz6tJCBpOXAwEq60/8QymcVaNMCWmpFHT3Lp7 5ZR2aMtCfbROkI/Ij/FPJBphWHWgylf5hROSqnqc3oDM9f07igWjUmiaj65wly+N U0PL67gGUvSbSg== X-ME-Sender: X-Sasl-enc: eOvutMS8lpYf3KFDSnczU6V/SGiUkc3+kam1pkL0a5Vd 1493654492 Received: from xps.localnet (55.17.136.77.rev.sfr.net [77.136.17.55]) by mail.messagingengine.com (Postfix) with ESMTPA id 017A6241E3; Mon, 1 May 2017 12:01:32 -0400 (EDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Cc: dev@dpdk.org, "Yao, Lei A" , stable@dpdk.org Date: Mon, 01 May 2017 18:01:29 +0200 Message-ID: <3754229.ISIS8DmyvR@xps> In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com> References: <1493206192-69422-1-git-send-email-pablo.de.lara.guarch@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 16:01:33 -0000 28/04/2017 09:47, Yao, Lei A: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > > > L3fwd power app monitors the RX queues to see if the polling frequency > > should be adjusted (the busier the queue, the higher the frequency). > > The app uses several thresholds in the ring to determine the frequency, > > being 96 the highest one, when frequency should be highest. > > > > The problem is that the difference between this value and the ring size > > is not big enough (128 - 96 = 32 descriptors), which means that > > if the descriptors are not replenished quick enough, queue might > > not be busy, but the app would think that it is, because 96th descriptor > > is set. > > > > Therefore, by increasing this gap (increasing the RX ring size), > > we make sure that this false measurement will not happen. > > > > Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX > > queue count") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara > I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency can > be changed according to the data throughput. > Tested-by: Lei Yao (lei.a.yao@intel.com) Applied, thanks