From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0041.outbound.protection.outlook.com [104.47.42.41]) by dpdk.org (Postfix) with ESMTP id 7584E201 for ; Tue, 21 Mar 2017 05:49:53 +0100 (CET) Received: from CY1PR03CA0001.namprd03.prod.outlook.com (10.174.128.11) by SN2PR03MB2271.namprd03.prod.outlook.com (10.166.210.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Tue, 21 Mar 2017 04:49:51 +0000 Received: from BY2FFO11FD023.protection.gbl (2a01:111:f400:7c0c::163) by CY1PR03CA0001.outlook.office365.com (2603:10b6:600::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Tue, 21 Mar 2017 04:49:51 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD023.mail.protection.outlook.com (10.1.15.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Tue, 21 Mar 2017 04:49:51 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2L4nlWY016912; Mon, 20 Mar 2017 21:49:48 -0700 To: "Hunt, David" References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com> Date: Tue, 21 Mar 2017 10:25:48 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131345453914996382; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39380400002)(39410400002)(39450400003)(39840400002)(39860400002)(39400400002)(2980300002)(1110001)(1109001)(339900001)(3190300001)(377454003)(189002)(24454002)(199003)(9170700003)(305945005)(76176999)(4326008)(110136004)(189998001)(2906002)(50986999)(5660300001)(65826007)(6916009)(229853002)(54356999)(23746002)(77096006)(356003)(106466001)(86362001)(230700001)(105606002)(53936002)(2950100002)(33646002)(8936002)(104016004)(38730400002)(31696002)(6246003)(65956001)(4001350100001)(47776003)(64126003)(31686004)(85426001)(83506001)(50466002)(8676002)(36756003)(65806001)(8656002)(81166006)(53546009)(54906002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2271; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD023; 1:KG8Pl0frOUp06FquQoaMo2FCfJ9HXeV+W+riF6MRIgGg+lZu4nBk7NmV0GoW9dMdHIC8+M3j4HqQ+FFu9/TvIYOOAwcbkBQDpSnD41RPIiWpMnLZgE4VD8y8T6P0P3qvc63joW1fM+KRuyn2aPMEPxchQNkW3wBj/ZIK4irhz+6/xllJ/0hLuA+RJrraxwnMZ8w1+FkqHweQHB7TA1D7wrb+/6gNh+BOifGmpq7nxxS1TpC7X+r9NXAMgH22vdYh0f1PLOYZgEwdQM0hE9Eby1j72wvcAkYMf7poT4Li1PrtKoklFNHN9Xi819/X2DZN7q0cWuVz1k07I6bnCLHyKDIEPU7+88Q80gGgTQhcs0FzAPMVHGXwntm87Q1cJqtixsDfB4ZEBFmf9BoI9rUFpTnR6psF02pC4ePG+7ZKOhrwl5IUWcQyYqE1JdRILnNTQko+sYDLW+rx8bLkqLXPapurLk6SPfYvbPugR5zDWW/qhTaA3wI6SiM3NFeflkJjb5iAITEMZDpuFCEDLs0iAH+BAyz7OpBV8cuODH8eGOP9GrkgnokqeSp0mWNuN8qtQCz+j4JL+W3E7IQIKIvqa+hPm1AR8k/PPB6S2jO06MyBe/K4sXZJsIkb+gaXWYhd X-MS-Office365-Filtering-Correlation-Id: 5b33869f-e117-4824-d235-08d47015b5d8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR03MB2271; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271; 3:qPpJXMZtUje54W2Fb5XStheTOL31XHG8V/kAydAwA03Z8Xk2Np+R+ZUoLaPsh0UsNst0OUH5PjTbCF0kg2JzEK6wow6tyaar8kM8DRt9dlzpn7daN9/Ti/o0gUpMY+V8BBauCYLR8RJ0iomM3n0YG8Uqv586KGq6sQWa3l6/tYPJeEdEKOTXn8Bl8pzzQM4iVkvehEp3YaVtnT6WdgYY8XsLq/4aTAQdAdSnVeAaCzzRzYLg+J3dXRCOlkqZdVpe+6BLDuhPPUMX5dPShD0WNLPbqnsTC9Dg791CGc/z4I59TTuPEqtF9+vPY7OaEJziMBcpmfjfiAcsQq7IPSzGKlGi/Sg9f4k0wYFIxUaRrvqVHkGRCCbAcZ/qg9pEsXyQ; 25:3zVc8iTazBWOUNldG1dRXwAZ9P3JYsTkDjF053sjVFA+/yT+YlyF/L7LYnGcG/zXhmDj++BfayRC9FrDoHV3ESQSU5Ih7+GCPXCJzGtleLOl3Cuz7os7/h/wpEmcqtOJHb2GKmfKbPYoKZTo3rWFRxbfytXDBcNdmTNTho6/D4QuBv8RgAzgQd0A9IKP7sU2xwWWt9ucKHWAsYAER7UZOsFHxj2B67RsBJtMT7KEEgs3xBzG6O4ZoxOQUfAGaUUDFMpTLB/B5tFIjDmB2sXGBm74IAZ1OA7n5CG3FIjG2XSO5GwX+8cOr/+uhnfsY7Td0LrDsnuyUDZevacaHU+hdv7clJzETTqE9FaLIAZBGT8a7yCcDlojWGiwu47+yhEOMrBe9E85JimiuiMLYQDEYxKqeRSsraV/DpUblCBgQgBlhaTMsfdP7ZuMdEp9G5nVoNjQp89aZUWWX2p4VNS64w== X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271; 31:ZEKm75USypakrQnQYoJJQ1IIq5+eoBSXa0K9iRMHpIvU98zhNZmSvP27fWaesPwy09Y4JCwGXHROUj3uteKqVrnb+fNoNz82lriJzcHdKv6bAziDK26bcow/wcRhh0FZajqu/lqhfB2/2QT2zZx0BNRVmyH4qJTRuASF3rhnzRrk/bQ8TpisedDxbvNXw5mSHbuhE/u2F9bP+fKye8RVpy784cw/MuTtXwWutL6yrGeDlnQ/wptSaN7QLMVIXhBO/lfQb41WJShsUCyxyqVadorDOupHwkoxhto7LL13k+g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13017025)(8121501046)(13015025)(13023025)(13024025)(13018025)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123565025)(20161123563025)(20161123556025)(20161123559025); SRVR:SN2PR03MB2271; BCL:0; PCL:0; RULEID:(400006); SRVR:SN2PR03MB2271; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271; 4:Y0nKFJTf0gYfF+/xWkLni5KKKYN30ekgbDICxY6JMFqTwb3QlII4VF9oPJ8fqjkcuDM3trD0+ZPteHKdGsKWPQecvGfFJ7ZDc17JvPHSj+MV+BZLH2ka3RSAcB1QUiM3zFZuaRko8ccN825L/n9WCf7v2gLoKkAoHX202ofZDBlWooNRdvZtuvzveqW3pCnokJRyvKpxoEhDJi7gnLdYEuSfG1CBALa98LBisxCNWhzTOG6sGQModPIyvj10HBj9LuTGEGKHtikFSXLHTKGsr98SHbTrLTgcZj9ASyQiv7XJYWAm1t5d04IMUlOlsKbj0fhUyZUUMGGkQ11nChIDAfVqwbawO1tJioUyxqxpY2lJ4ISda0Yt768eWMmsbykrmqych9U0DoYQgR70ScM9u011BoQ8l81Qm+dOd3qP5YfdMDWVNC6Pq1UhoBnyoBqeunhON2SKdsRgcbR8/wklpt9Ekp7XB3e0ZuDRda7GQ6R7WAUug8C41JjaL6yAlFp6wbnF5WG8A0n9xwWfjfbQIbfQhBM9K3gepyCg0rDwHuoX9DAgjufLoFOsv1CMIuoZ2fqXM1bBi9Q6AfIzx6QxKmAyoR/PzVtMyrm9+D6zK7sma5CaaDo5BwfMBv4bQQ2/+O+r4tRa0LGJBl8bGHvNN6lROIQ4/wZ+TRxvKW4utJk+lbJeACitFMHcOTajdAX60Ie9A3aW5XcEj8ffdLGEow== X-Forefront-PRVS: 02530BD3AA X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR03MB2271; 23:3nNZnHfWQh4odni6p30v3tCXXXSRz2jKxqDT/?= =?Windows-1252?Q?Gs8fsIdZzJWvqWM6UbWDCd+Rg5HS5UDPwddBDubEofvTcjJScT/Dozlw?= =?Windows-1252?Q?uldKLrZ09tAJxJZnIxJNFLt1aohoJ+C9vt7JzoaZINLb888YIrmQd68a?= =?Windows-1252?Q?bwpu+XrbeZXDtBb6sNNQnPOXFnpSbYreIgf+D8C6Gi9Vki7cgZEH/njO?= =?Windows-1252?Q?vImv3niw+RqOW9bfDnLoiZioVqGnrzF7EnytyJ9Kya1FOEFq1yw3MOOb?= =?Windows-1252?Q?vutUoun2Ysv85wGotym8hbtElSOfF5ne5j89ZLyMjttvrE8beJi1O31v?= =?Windows-1252?Q?8N9AQiqR5ydKZ0VoA/LpvecGi4egS6GhbSFF6WOC7SRbFpcJqd3DxdmW?= =?Windows-1252?Q?QrTXREHn9D6TIw/c5uJ0RBV/Ndv2LJAX53sBqSvaQVF94wXqUt96vbUN?= =?Windows-1252?Q?ysqX2KQUd7/+u0O53qNsmMM5bduHfciOojG+Tb9vUyh95PT2c7AY26bI?= =?Windows-1252?Q?XMIbOBMPMamU9yYXnxO/0J6ztSgc3Y2bUZU9bj37WHliGkWi5k8gqSlG?= =?Windows-1252?Q?0fSq5HYK6AHwQ/ktKjg8xDBW6+7WJEXQQDo2QbqmQpmuzu9vUiwyPPwm?= =?Windows-1252?Q?hED3H8u5gzuWNrwhE3sCXGw03kGhoZ36m65zL8hBzZV4T26f7qubNIaX?= =?Windows-1252?Q?H9Y6LFAmkrr/y/29Rfd/vvjuH17rllFlpxOn6YBAMeg5ggn7tLD5pt0j?= =?Windows-1252?Q?ca835iNwLikt3GjB4WGAo/kOOfPaDr41+TbdJK8QbtuyijfXwbdcBbex?= =?Windows-1252?Q?C1n+ZUQRp00975BFtZD7odoHcMdUaCGiaKpVnGuv2KXtmdKlu/EadD21?= =?Windows-1252?Q?mqGsVhmyOnZv0qVytogQlyCEET7+pPn+rX2Y+rDIl/qt8Aoo5n4tJICQ?= =?Windows-1252?Q?UCST+3PX8eC0a4mV24nyWhZCOad6ol2urHSrdkHu3jaMfgOXeDC8lZt8?= =?Windows-1252?Q?SQ4742BPRVFr49oi/Kybb3TxSYgxhCxB3lfCxCjlrX9Gx5OgWjELLaqU?= =?Windows-1252?Q?6nvAcEdvN0Ef1Bl2KIsFXiG5Q2wjQAHAPmQRLi9Si8eJnVB3d8IJt1UC?= =?Windows-1252?Q?rw7RyTMaXHFPvdPWvMuUCl2QhnNTQexuj5/aFx56JkJzc77suijRpXGs?= =?Windows-1252?Q?Ovp5r3BQmj9Rr1+PRW6MlAqZjIcdlvPTrO8pp4AliE4J6vveneJcE/zS?= =?Windows-1252?Q?CrzB2JckawGjv87VR52UdY4B4D77uzb/hGkru3gIG38nlRPHrmFC9GXv?= =?Windows-1252?Q?1ArsSjVzZjRNgv14ouuz1O6zPv7vDxJ9qmpAqxSymaJX7qrlJD5fQ7NR?= =?Windows-1252?Q?1emKn7T0TAIexSnMq+DbmdsPtyiAuHGldmAI5qpla16InbZAyGlKYImg?= =?Windows-1252?Q?P2mKNoh5cL2V7haduCW5EKCR0FSxVFA+DKR3lYGGZoEhqI3JHpaguRf1?= =?Windows-1252?Q?sDBRNbaSYrHQxzfUVWLuPB7AwmZiOIgezr7w1vXW34Vj35M87GCQ+YId?= =?Windows-1252?Q?teGuotbOkzu5mvhMjJhItF8PEqMSNg+nQW5E4fGK+8TssckXcp3Ntavk?= =?Windows-1252?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271; 6:MjMi+5WEEyLk82y+We81TfuKP5f+tQut7ycBAScZ/bdvv1BSEEuhWr+iNwygmRNc6bIeetpkJrPVCqKhlJpSJ0+5XtHzQxHmR8jSLnAgiqB9M/16QmOKV1YjcltDIjT8GqHoKg79BFzrFhKM3F7fuzdY8Cd5fjYGnpfKO8l1/C4WOHfFaW5+9VUV1GGp2sGyOYE/65QumwdLMehjVMeNIGg9hdqR74rS6G6D1v6bK6NWzsMl8m/szpCVYD0MgLkFcSYPJuBI3TpQkMBmoCZ6nsDOq9z7+QyKvSTA3qJRrrortPJZrAO+4RKAmMTqds04mwApF9Eoin0HzaE5QJWSfZcNbaerS3zh8v6ypLhnWCb2oJN+lJ6Mb/ztY1CFKtVeHUix8mm72jlYzHn486lVI1X9V15Xk6nK6LS/wbOSDQM=; 5:WdyvAGVG2x6h49K+vDKBCQ3V2T5P6fF5Yv3qmWhYENd95dGu+BhqlowXPMHCPnT/hcPrMiAgHHu1QM/UG6X4RC1MQGQJWzEHjUrKwbKFMAgAccmuerKIpL7F82IYpr81Cb5Xn/5Sm7qXEhIdWtxzzrfEj9MtxAuqhFi/KjawwlOWM53ky/pw0y/dmMmB2o+q; 24:29gKc9APU2yg18AGBkunpMuhhUM5Skj7wFy1F4GjBatTstehAMxDOY5rGqkAxizu+HO7fxBlgC530o9EiQ6beYaVfX70Ha/nCjoXD+BwUWE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271; 7:1BjXJqa/5I0S/xgpyphtWvAp0sbzI7EfW71W4r+fK8Ew9U9XHAukPPZsyK0eUokwk+hd8mP4Mrmovi5HX6r6ezJCt7S+PU5osnRNUzLLJMLtrEWfX9D6ZKd1RMMvPUBTPALRDVZ9g2JrxZtlCUfw3yQq7dG5Q2kr2Eg79Li9+U+L1Wkw1X9uK1etkbvpi3L8AIvCkNnPXJZOAU0Lzi4B1SBIMvRNdVw0srsI9Yd8XH/2TftacYsiV2O4guXhKN94bXvpmfG+lZf+Wtvb8bb1WAn4naoaIDf9ciQPCDU8a/1hx2+MmKkZ6MoOjircf2xuFuJX1kFPYmqUAZg0kUPDdA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2017 04:49:51.1720 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2271 Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 04:49:54 -0000 Hello David, On Monday 20 March 2017 08:20 PM, Hunt, David wrote: > > On 20/3/2017 10:03 AM, Shreyansh Jain wrote: >> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. >> Stack mempool handler moved from lib/librte_mempool into drivers/mempool. >> <...> >> -} >> - >> -static struct rte_mempool_ops ops_stack = { >> - .name = "stack", >> - .alloc = stack_alloc, >> - .free = stack_free, >> - .enqueue = stack_enqueue, >> - .dequeue = stack_dequeue, >> - .get_count = stack_get_count >> -}; >> - >> -MEMPOOL_REGISTER_OPS(ops_stack); > > Shreyansh, > Could I suggest you add the parameter "--find-renames" when > generating the patch files, as this will reduce the size of the patches > significantly, making for easier review. The patch line count in this > particular case would be reduced by approx 75%. Thanks for suggestion. Yes, I forgot to use this option while creating this patch. If there are comments and v2 needs to be created, I will keep this in mind. > Regards, > Dave. > >