DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide
Date: Wed, 09 Dec 2015 16:09:21 +0100	[thread overview]
Message-ID: <3756278.RbTW4O93Bj@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023FFEB4@IRSMSX103.ger.corp.intel.com>

2015-12-09 14:50, Mcnamara, John:
> Also, as a general note, not just to this document/patch.
> 
> I don't think the "user@target:~$" prefixes used in some DPDK
> Doc commandlines is useful.
> 
> It prevents a straight copy and paste for testing, it makes the
> literal block lines longer than they should be, it isn't used
> consistently everywhere, it is visually distracting (in some
> cases it is longer than the command being shown), and it isn't
> always correct (I presume in the above case of "user@target" you
> would need run the application as sudo if you are a non root
> user).
> 
> Any objections to removing these as documents are updated?

Generally speaking, +1 to remove extra bytes :)

  reply	other threads:[~2015-12-09 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 12:35 Bernard Iremonger
2015-12-09 13:36 ` Xie, Huawei
2015-12-09 14:43 ` Mcnamara, John
2015-12-09 16:10   ` Iremonger, Bernard
2015-12-09 14:50 ` Mcnamara, John
2015-12-09 15:09   ` Thomas Monjalon [this message]
2015-12-09 16:14     ` Iremonger, Bernard
2015-12-10  6:40       ` Yuanhan Liu
2015-12-09 17:18 ` [dpdk-dev] [PATCH v2 " Bernard Iremonger
2015-12-10  6:52   ` Yuanhan Liu
2015-12-10  9:58     ` Iremonger, Bernard
2015-12-10 12:10       ` Xie, Huawei
2015-12-10 13:19         ` Iremonger, Bernard
2015-12-10 13:33           ` Xie, Huawei
2015-12-10 11:23   ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2015-12-14  0:23     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3756278.RbTW4O93Bj@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).