Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/i40e: fix dropped packets statistics name

["Eelco Chaudron" <echaudro@redhat.com>]

Looks good to me…

Acked-by: Eelco Chaudron <echaudro@redhat.com>

On 3 Jun 2019, at 10:31, David Marchand wrote:

> i40e and i40evf currently use two different names for the statistic on
> dropped packets on the rx and tx sides.
> Let's prefer i40evf so that all statistics are suffixed with _packets.
>
> This also avoids a statistic name conflict in OVS.
>
> Fixes: f4a91c38b4ad ("i40e: add extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c 
> b/drivers/net/i40e/i40e_ethdev.c
> index 7fa9e1b..2384d4d 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off {
>  	{"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)},
>  	{"rx_multicast_packets", offsetof(struct i40e_eth_stats, 
> rx_multicast)},
>  	{"rx_broadcast_packets", offsetof(struct i40e_eth_stats, 
> rx_broadcast)},
> -	{"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)},
> +	{"rx_dropped_packets", offsetof(struct i40e_eth_stats, 
> rx_discards)},
>  	{"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>  		rx_unknown_protocol)},
>  	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
>  	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, 
> tx_multicast)},
>  	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats, 
> tx_broadcast)},
> -	{"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)},
> +	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, 
> tx_discards)},
>  };
>
>  #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \
> -- 
> 1.8.3.1