From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6858743B3A; Sun, 18 Feb 2024 14:38:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DECCE40262; Sun, 18 Feb 2024 14:38:44 +0100 (CET) Received: from wfout3-smtp.messagingengine.com (wfout3-smtp.messagingengine.com [64.147.123.146]) by mails.dpdk.org (Postfix) with ESMTP id B275C4021D for ; Sun, 18 Feb 2024 14:38:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id 7739B1C0007E; Sun, 18 Feb 2024 08:38:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 18 Feb 2024 08:38:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708263519; x=1708349919; bh=9n4MXtSWRYGT/FbcnECY41q331rgqfk6NI5L+q04Fow=; b= bVFX4VJXGTmZEok9i/LKXxul066pCP88psCCnfCwU8GCjRCNhV0GFxQyKkC+IGZB dHaP79juuqp+jF3/kbdK4yJZJld2bEN0VGZd6AfjRYiPhuyoEqwXERpaHNi2iYxa gX6WC3ArBRnbRoptJcIi3AVHfWM31mqvA+A6l8ZOrgwscI2a3grTOxZ7Kuxcf3Dm /etWDLTE6CV6zrqJiKCiGNLHjyWI0cKbf1Nu2dViFFVbgqE4w2dW3VnZKNx02WuM 7O2kO55Cz3UGpZpigRZ75wt/me7tx2YIAeSuvJv2BCBxbUcyddysTG522bisblzl /2zzBfRnCPaBHia++Tajvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708263519; x= 1708349919; bh=9n4MXtSWRYGT/FbcnECY41q331rgqfk6NI5L+q04Fow=; b=N 8sLsRNX0ns1rgfiqOtjlpKES/+TLE/W2et/9Lb5UCzXoH7gb5EJZnUkCQVbsUU4k NPBJs+0qxjWfRzSN3GBh8108TJ65AS5wJAaNN849xVQbEEWRSIx0bAz35FebGoOP /u7JKePKySufJqZdlQ+OwABVAfqjff9OACnMb9+tsCWmmxaK8P2CJxIQEJYOj8mC hwlt/ZC0NkHoCTlZEm0YJvkykieMBRDTjllew1hcfnfCt9mOVguPx9hupGDdworW c3UiX9ogLJVOyHMCTIaBoZndguqJbW+3JhJEj+NK6Xq8BrcI1G1DnOzc+27V6s/8 2W2x4rECiD8OYybeyUPEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeigdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 08:38:37 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori Subject: Re: [PATCH 00/15] use GCC/MSVC compatible __VA_ARGS__ Date: Sun, 18 Feb 2024 14:38:35 +0100 Message-ID: <3760961.C4sosBPzcN@thomas> In-Reply-To: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/02/2024 22:49, Tyler Retzlaff: > MSVC does not support GCC args... forwarding of args replace > with ... and __VA_ARGS__ when forwarding. Both forms of > forwarding are a compiler extension but the latter is supported > by both MSVC and GCC. You use the non-standard ", ## __VA_ARGS__" which would not compile in pedantic modes, and possibly with other compilers. I remember a private chat where I recommended you to use this: lib/eal/include/rte_common.h /** * ISO C helpers to modify format strings using variadic macros. * This is a replacement for the ", ## __VA_ARGS__" GNU extension. * An empty %s argument is appended to avoid a dangling comma. */ #define RTE_FMT(fmt, ...) fmt "%.0s", __VA_ARGS__ "" #define RTE_FMT_HEAD(fmt, ...) fmt #define RTE_FMT_TAIL(fmt, ...) __VA_ARGS__ Why not using it?