From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 06C4C3777 for ; Thu, 21 Jul 2016 10:27:57 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id q128so13527215wma.1 for ; Thu, 21 Jul 2016 01:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=0xLQTuAUnhV4Yv4XSMwzw8HFzyyfolg+IiMgcacJbrM=; b=vT5ypwBZJo0MrcpCf7NkwpcUTtCzKUppkNaQDqaEqI89eBGBHSRE0S7UwT0W7x5MhF k/VkzxLb1w0CHHfV0LO4B6Ss6Vfn0CtoqmacFizNiCLOjhvWCBJpUifnGdoM1kNfXt93 N5pGjlzfQgKgwJQFY8Y1EmCkW/NZ6sH7f2o+0qzTO773oHYdakDvlc75FbX3P1+YPht/ dFES0mojEYnbFWFC1SqAsP1n6qXrx0fpMseZT25ru4j5wdI9tHRkUy6J+9Cv5qI60gAl bNfOUEhA3p7G2O3JkcP2gL5aGJak4QO7WqTBLPUiM7P+pj+ORlPzIFDnEJE2z50DoKzc Lqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0xLQTuAUnhV4Yv4XSMwzw8HFzyyfolg+IiMgcacJbrM=; b=F14bQpJ4M/8/PkRjEtBVhjhQrOuycwu16RdvWgGzUOgi0CPsvljaGOj2z9xO8PEXTY DiLFRs1Lj0olGK1v68mU0JqQKjZfWz9F4y6Lal51qa+UxwO600e8SijZt9CTopKEJkwF bRWw2/ewULyyt0JnPW6vS5RLeP5rRAHcXrgpeaCxREEbMLLOB2I3WcRZsxUlCGOAqxTI HoMlJNGkfcKe4IIUgTPrXlgGU8jRhpPRJzr49UgXuOTxUqlh75MjKKZZV7a1BjtZYzL0 asg7ZXBhUNH1vF+isEo9LyuKk8wNKOPric7xxZChWb1dgSH9wyYC49CwxOOgIOzBP5q1 f0YA== X-Gm-Message-State: ALyK8tL/tZA0H+HWjoGxjtAHsvuGRGiT8aGA+2TPDIpM3yMoJ9oj0u47XX949kFv3Vu7O4JP X-Received: by 10.194.63.52 with SMTP id d20mr5661221wjs.167.1469089676852; Thu, 21 Jul 2016 01:27:56 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v134sm2133333wmf.10.2016.07.21.01.27.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 01:27:55 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: Christian Ehrhardt , dev , Ferruh Yigit Date: Thu, 21 Jul 2016 10:27:54 +0200 Message-ID: <3763917.FNUyifCyb9@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1468857995-130392-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1468935637-39937-1-git-send-email-sergio.gonzalez.monroy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mk: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 08:27:57 -0000 > > The sed syntax of '0,/regexp/' is GNU specific and fails with > > non GNU sed in FreeBSD. > > > > To solve the issue we can use awk instead to remove duplicates. > > > > The awk script basically keeps the last config value, while > > maintaining order and comments from original config file. > > > > Fixes: b2063f104db7 ("mk: filter duplicate configuration entries") > > > > Signed-off-by: Sergio Gonzalez Monroy > > Hi, > the order changed, but IMHO actually it improved. > Things are now at the place they were before, but with the overwriting > config value that came later - that is the best of both worlds. > > Tested a few config runs pre/post patch and compared them sorted (equal) > and unsorted - now configs slotted in where they belong. > Thanks for updating Sergio > > Acked-by: Christian Ehrhardt Applied, thanks