From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05641A0350; Mon, 18 Nov 2019 16:15:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92360B62; Mon, 18 Nov 2019 16:15:03 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 3E0D39E4 for ; Mon, 18 Nov 2019 16:15:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1A98266C; Mon, 18 Nov 2019 10:14:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 18 Nov 2019 10:14:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MIytdUuff5uEGF1wvjE40QS/2nALtyezfYATAHWHbRE=; b=fSTx5f1uFxyo Z8nu5ODd+og33R9vpi0564hNkNKWcTHw33Nak2HfWTJNpnwAjgD45VKTy6TrWGF7 RB6xw30QHop5wg0w56dtj3+HCFnGYvbAMKcQvfXssxr09avKhuZxdwuG6llN/0p7 ZpF3dHSM2UsoswXWtpaScGpSgYC/F4k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MIytdUuff5uEGF1wvjE40QS/2nALtyezfYATAHWHb RE=; b=l9r+dHp7d1rgH+HeCw4ntET7tIp5uASkVVaCTUvNiZ8mFsH12Fp4tV7Cx OYD8lUiJ7Yo/IWyD14cIz64grfd7fftyL3YUnYo1J0Kj+Lt7eT45f2yjYbFDA0zW hrbVMv2S57dtxh2TaMFONuuT1CKJF0/UxHW+hgoTfV3vAmgO6Mwiy3RzrHOtn3wN lYfncJChX/qVhFf848tFQP9boAYP/6haEMp9KSix2fCi/71Ey1iiwJ19zjfyFp46 UrISqlTSTFUf/iAAaK3B2eL5vOc+4mBMkFlNP/+YOLQZ9b14g/8wiMkj9m3jnPpV nDTZut08ug3luW8SzXE0RxEIFbOAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegiedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E24C680061; Mon, 18 Nov 2019 10:14:56 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, Bruce Richardson , david.marchand@redhat.com Date: Mon, 18 Nov 2019 16:14:54 +0100 Message-ID: <3766664.SyXFxqzVBa@xps> In-Reply-To: <20191112131556.16668-1-ferruh.yigit@intel.com> References: <20191112131556.16668-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/11/2019 14:15, Ferruh Yigit: > This patch functionally reverts the patch in fixes line to not have any > hardcoded library path in the final binary for the security reasons, in > case this binary distributed to production environment. What about meson? There are these rpaths: $ORIGIN/../lib $ORIGIN/../drivers > RPATH only added in RTE_DEVEL_BUILD case and this binary shouldn't > distributed, but still removing it to be cautious. For convenience, we could keep adding rpath for internal apps. > --- a/devtools/test-null.sh > +++ b/devtools/test-null.sh > if ldd $testpmd | grep -q librte_ ; then > + export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH > libs='-d librte_mempool_ring.so -d librte_pmd_null.so' There is an issue in this change, because $build may be undefined. It can be fixed with adding this line: +[ -f "$testpmd" ] && build=$(dirname $(dirname $testpmd)) [ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd [ -f "$testpmd" ] || testpmd=$build/app/testpmd